[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: ToC generation step
From: Pierre Stirnweiss <pstirnweiss () googlemail ! com>
Date: 2010-01-27 12:26:05
Message-ID: af76e3dc1001270426p60611e68x3e86377f269a0087 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
or even better, i think it ought to be a command in the textshape (see list
creation,... in textshape/commands).
PierreSt
On Wed, Jan 27, 2010 at 1:13 PM, Pierre Ducroquet <pinaraf@pinaraf.info>wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2734/#review3906
> -----------------------------------------------------------
>
>
>
> trunk/koffice/libs/kotext/KoTextEditor.cpp
> <http://reviewboard.kde.org/r/2734/#comment3276>
>
> That whole piece of code should be in KoTableOfContents, shouldn't it ?
>
>
> - Pierre
>
>
> On 2010-01-27 10:41:29, Jean-Nicolas Artaud wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/2734/
> > -----------------------------------------------------------
> >
> > (Updated 2010-01-27 10:41:29)
> >
> >
> > Review request for KOffice.
> >
> >
> > Summary
> > -------
> >
> > Here Is the ToC generation step.
> >
> > http://img687.imageshack.us/img687/5207/tocgeneration.png
> >
> > I think somethings have to be improved:
> > * The style for instance are not really adapted, but if you open
> existing contents styles, it works really good (see the screenshots).
> > * pages number is not actually updated because a new signal is
> necessary : layoutFinished
> >
> >
> > Diffs
> > -----
> >
> > trunk/koffice/kword/part/KWDocument.cpp 1079518
> > trunk/koffice/kword/part/kword.rc 1079518
> > trunk/koffice/libs/kotext/KoTextEditor.h 1080908
> > trunk/koffice/libs/kotext/KoTextEditor.cpp 1080908
> > trunk/koffice/libs/kotext/styles/KoParagraphStyle.h 1080908
> > trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1080908
> > trunk/koffice/plugins/textshape/TextTool.h 1079518
> > trunk/koffice/plugins/textshape/TextTool.cpp 1079518
> >
> > Diff: http://reviewboard.kde.org/r/2734/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Jean-Nicolas
> >
> >
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel
>
[Attachment #5 (text/html)]
or even better, i think it ought to be a command in the textshape (see list \
creation,... in textshape/commands).<br><br>PierreSt<br><br><div \
class="gmail_quote">On Wed, Jan 27, 2010 at 1:13 PM, Pierre Ducroquet <span \
dir="ltr"><<a href="mailto:pinaraf@pinaraf.info">pinaraf@pinaraf.info</a>></span> \
wrote:<br> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div \
class="im"><br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
</div><a href="http://reviewboard.kde.org/r/2734/#review3906" \
target="_blank">http://reviewboard.kde.org/r/2734/#review3906</a><br>
-----------------------------------------------------------<br>
<div class="im"><br>
<br>
<br>
trunk/koffice/libs/kotext/KoTextEditor.cpp<br>
</div><<a href="http://reviewboard.kde.org/r/2734/#comment3276" \
target="_blank">http://reviewboard.kde.org/r/2734/#comment3276</a>><br> <br>
That whole piece of code should be in KoTableOfContents, shouldn't it ?<br>
<br>
<br>
- Pierre<br>
<div class="im"><br>
<br>
On 2010-01-27 10:41:29, Jean-Nicolas Artaud wrote:<br>
><br>
> -----------------------------------------------------------<br>
> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="http://reviewboard.kde.org/r/2734/" \
target="_blank">http://reviewboard.kde.org/r/2734/</a><br> > \
-----------------------------------------------------------<br> ><br>
</div>> (Updated 2010-01-27 10:41:29)<br>
<div><div></div><div class="h5">><br>
><br>
> Review request for KOffice.<br>
><br>
><br>
> Summary<br>
> -------<br>
><br>
> Here Is the ToC generation step.<br>
><br>
> <a href="http://img687.imageshack.us/img687/5207/tocgeneration.png" \
target="_blank">http://img687.imageshack.us/img687/5207/tocgeneration.png</a><br> \
><br> > I think somethings have to be improved:<br>
> * The style for instance are not really adapted, but if you open existing \
contents styles, it works really good (see the screenshots).<br> > * pages \
number is not actually updated because a new signal is necessary : layoutFinished<br> \
><br> ><br>
> Diffs<br>
> -----<br>
><br>
> trunk/koffice/kword/part/KWDocument.cpp 1079518<br>
> trunk/koffice/kword/part/kword.rc 1079518<br>
> trunk/koffice/libs/kotext/KoTextEditor.h 1080908<br>
> trunk/koffice/libs/kotext/KoTextEditor.cpp 1080908<br>
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.h 1080908<br>
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1080908<br>
> trunk/koffice/plugins/textshape/TextTool.h 1079518<br>
> trunk/koffice/plugins/textshape/TextTool.cpp 1079518<br>
><br>
> Diff: <a href="http://reviewboard.kde.org/r/2734/diff" \
target="_blank">http://reviewboard.kde.org/r/2734/diff</a><br> ><br>
><br>
> Testing<br>
> -------<br>
><br>
><br>
> Thanks,<br>
><br>
> Jean-Nicolas<br>
><br>
><br>
<br>
_______________________________________________<br>
koffice-devel mailing list<br>
<a href="mailto:koffice-devel@kde.org">koffice-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/koffice-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br> \
</div></div></blockquote></div><br>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic