From koffice-devel  Sun Jan 24 19:28:55 2010
From: "Thomas Zander" <zander () kde ! org>
Date: Sun, 24 Jan 2010 19:28:55 +0000
To: koffice-devel
Subject: Re: Review Request: add filnameOfStore() to KoStore
Message-Id: <20100124192855.24483.36760 () localhost>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=126436130503322


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2642/#review3850
-----------------------------------------------------------



trunk/koffice/libs/store/KoStore.h
<http://reviewboard.kde.org/r/2642/#comment3238>

    unneeded virtual



trunk/koffice/libs/store/KoStore.h
<http://reviewboard.kde.org/r/2642/#comment3239>

    trailing whitespace



trunk/koffice/libs/store/KoStore_p.h
<http://reviewboard.kde.org/r/2642/#comment3240>

    please use copyright from the original file you renamed.


- Thomas


On 2010-01-24 18:59:15, Casper Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2642/
> -----------------------------------------------------------
> 
> (Updated 2010-01-24 18:59:15)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Added a filenameOfStore() method and some code to make it work
> 
> When loading ODF sometimes there is a href to a file relative to the store, so it's important that the loading code can find out what the url of the store is in order to resolve the relation.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/libs/store/CMakeLists.txt 1079527 
>   trunk/koffice/libs/store/KoDirectoryStore.h 1079527 
>   trunk/koffice/libs/store/KoEncryptedStore.h 1079527 
>   trunk/koffice/libs/store/KoEncryptedStore.cpp 1079527 
>   trunk/koffice/libs/store/KoStore.h 1079527 
>   trunk/koffice/libs/store/KoStore.cpp 1079527 
>   trunk/koffice/libs/store/KoStoreBase.h 1079527 
>   trunk/koffice/libs/store/KoStoreBase.cpp 1079527 
>   trunk/koffice/libs/store/KoStore_p.h PRE-CREATION 
>   trunk/koffice/libs/store/KoTarStore.h 1079527 
>   trunk/koffice/libs/store/KoTarStore.cpp 1079527 
>   trunk/koffice/libs/store/KoZipStore.h 1079527 
>   trunk/koffice/libs/store/KoZipStore.cpp 1079527 
> 
> Diff: http://reviewboard.kde.org/r/2642/diff
> 
> 
> Testing
> -------
> 
> I'm using it loacaly in my videoshape and it works.
> Not all means of creating a store will currently result in a valid url returned from filenameOfStore() but this is hinted at in the documentation.
> 
> 
> Thanks,
> 
> Casper
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel