[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Proposal: using generated code in the powerpoint import filter
From:       Inge Wallin <inge () lysator ! liu ! se>
Date:       2010-01-24 19:13:49
Message-ID: 201001242013.50120.inge () lysator ! liu ! se
[Download RAW message or body]

On Friday 22 January 2010 16:00:24 Jos van den Oever wrote:
> On Friday 22 January 2010 15:04:36 Inge Wallin wrote:
> > On Friday 22 January 2010 14:30:49 Jos van den Oever wrote:
> > > On Wednesday 20 January 2010 13:15:10 Jos van den Oever wrote:
> > > > I would like to start a private git branch to switch to generated
> > > > code in the filter and send a (huge) patch to review board once it's
> > > > done.
> > >
> > > Here is the first version of the patch:
> > > http://ktown.kde.org/~vandenoever/0001-Port-to-new-ppt-parser.patch
> > >
> > > It compiles and runs fine but document conversion is flawed at the
> > > moment. The fixes for document conversion will not affect the general
> > > patch much, so I'm putting it up for review already.
> > >
> > > I've also reorganized the file layout. After applying the patch the
> > > filter directory looks like this:
> > >
> > > powerpoint/
> > > powerpoint/datetimeformat.cpp
> > > powerpoint/ppttoodp.cpp
> > > powerpoint/ppttoodp.h
> > > powerpoint/pictures.h
> > > powerpoint/parsedpresentation.cpp
> > > powerpoint/powerpointimport.h
> > > powerpoint/datetimeformat.h
> > > powerpoint/ppttoodpmain.cpp
> > > powerpoint/pole.cpp
> > > powerpoint/pictures.cpp
> > > powerpoint/pole.h
> > > powerpoint/parsedpresentation.h
> > > powerpoint/mso
> > > powerpoint/mso/simpleParser.h
> > > powerpoint/mso/leinputstream.h
> > > powerpoint/mso/simpleParser.cpp
> > > powerpoint/powerpointimport.cpp
> > > powerpoint/CMakeLists.txt
> > > powerpoint/kpresenter_powerpoint_import.desktop
> >
> > Awesome work, but what happened to CamelCasing?
> 
> Just tell me what you'd like to camel-cased. Are you talking about the
>  files or do you want more camel case in the code?

I was thinking of the filenames in this case.  If you have classes in them, 
they should be camel cased, and so should the filenames of the files that 
contain them.

> As far as variable names derived from the PPT spec goes, I've kept the
>  names the same as in the spec as much as possible. All these names are in
>  the PPT namespace.

That's great.

	-Inge
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]