[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: add filnameOfStore() to KoStore
From:       "Casper Boemann" <cbr () boemann ! dk>
Date:       2010-01-21 19:26:15
Message-ID: 20100121192615.16880.13316 () localhost
[Download RAW message or body]



> On 2010-01-21 16:13:01, Thomas Zander wrote:
> > 

ok. If these are changed will it be ok. or should i still upload a new diff?


> On 2010-01-21 16:13:01, Thomas Zander wrote:
> > trunk/koffice/libs/store/KoStore.h, line 30
> > <http://reviewboard.kde.org/r/2642/diff/3/?file=17442#file17442line30>
> > 
> > Is this include still needed?

no i'll remove before commit


> On 2010-01-21 16:13:01, Thomas Zander wrote:
> > trunk/koffice/libs/store/KoStore.h, line 120
> > <http://reviewboard.kde.org/r/2642/diff/3/?file=17442#file17442line120>
> > 
> > Please avoid those trailing spaces

ok


> On 2010-01-21 16:13:01, Thomas Zander wrote:
> > trunk/koffice/libs/store/KoStoreBase.h, line 44
> > <http://reviewboard.kde.org/r/2642/diff/3/?file=17443#file17443line44>
> > 
> > Why is this virtual?

because i only have KoStore as accesspoint so it needs to be virtual=0 there and \
implemented here.


- Casper


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2642/#review3776
-----------------------------------------------------------


On 2010-01-20 18:54:26, Casper Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2642/
> -----------------------------------------------------------
> 
> (Updated 2010-01-20 18:54:26)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Added a filenameOfStore() method and some code to make it work
> 
> When loading ODF sometimes there is a href to a file relative to the store, so it's \
> important that the loading code can find out what the url of the store is in order \
> to resolve the relation. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/store/KoEncryptedStore.cpp 1077639 
> trunk/koffice/libs/store/KoStore.h 1077639 
> trunk/koffice/libs/store/KoStoreBase.h 1077639 
> trunk/koffice/libs/store/KoStoreBase.cpp 1077639 
> trunk/koffice/libs/store/KoTarStore.cpp 1077639 
> trunk/koffice/libs/store/KoZipStore.cpp 1077639 
> 
> Diff: http://reviewboard.kde.org/r/2642/diff
> 
> 
> Testing
> -------
> 
> I'm using it loacaly in my videoshape and it works.
> Not all means of creating a store will currently result in a valid url returned \
> from filenameOfStore() but this is hinted at in the documentation. 
> 
> Thanks,
> 
> Casper
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]