[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: ***UNCHECKED*** DataCenterMap
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2010-01-21 7:57:19
Message-ID: 201001210857.19987.t.zachmann () zagge ! de
[Download RAW message or body]

Hello,

> So, here is my patchset that essentially does this.
> If you apply these patches you might just want to do something like;
> git show [sha1] libs/flake
> which gives you the patch limited to that directory so you can easier check
> the differences in headers.
> 

I got the following compile error:

/home/tz/develop/kde/svn/koffice-
datacenter/kpresenter/plugins/eventactions/sound/KPrSoundEventAction.cpp: In 
member function ‘virtual void 
KPrSoundEventAction::saveOdf(KoShapeSavingContext&) const':                           \
                
/home/tz/develop/kde/svn/koffice-
datacenter/kpresenter/plugins/eventactions/sound/KPrSoundEventAction.cpp:89: 
error: ‘KoDataCenter' is an inaccessible base of ‘KPrSoundCollection'             \


looks like you missing a public before the KoDataCenter
+class KPRESENTER_EXPORT KPrSoundCollection : public QObject, KoDataCenter {

-    d->title = KoShapeRegistry::instance()->value( TextShapeId )-
> createDefaultShapeAndInit( parent->parent()->dataCenterMap() );
+    d->title = KoShapeRegistry::instance()->value( TextShapeId )-
> createDefaultShape();

The resource provider should be passed here.

+    QVariant variant;
+    variant.setValue<void*>(new VideoCollection(manager));
+    manager->setResource(VideoCollection::ResourceId, variant);
 
how about using Q_DECLARE_METATYPE for resources. That will allow us to avoid 
the void casts?

+    /**
+     * Set the collection used in the shape.
+     */
+    void setVideoCollection(VideoCollection *collection) { m_videoCollection 
= collection; }

The implementation should be moved to the cpp file.

Looks like this two files should not be in the patch:
Index: kword/part/frames/tests/TestBasicLayout.cpp
Index: kword/part/frames/tests/TestBasicLayout.h

Unfortunately still not finished.

Thorsten
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]