[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: add filnameOfStore() to KoStore
From:       "Casper Boemann" <cbr () boemann ! dk>
Date:       2010-01-20 16:18:10
Message-ID: 20100120161810.15126.45736 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2642/
-----------------------------------------------------------

(Updated 2010-01-20 16:18:09.876653)


Review request for KOffice.


Changes
-------

Have change it to use the m_url and m_localFileName in KoStoreBase
And the actual implementations are now setting those values in their constructors


Summary
-------

Added a filenameOfStore() method and some code to make it work

When loading ODF sometimes there is a href to a file relative to the store, so it's \
important that the loading code can find out what the url of the store is in order to \
resolve the relation.


Diffs (updated)
-----

  trunk/koffice/libs/store/KoEncryptedStore.cpp 1077639 
  trunk/koffice/libs/store/KoStore.h 1077639 
  trunk/koffice/libs/store/KoStoreBase.h 1077639 
  trunk/koffice/libs/store/KoStoreBase.cpp 1077639 
  trunk/koffice/libs/store/KoTarStore.cpp 1077639 
  trunk/koffice/libs/store/KoZipStore.cpp 1077639 

Diff: http://reviewboard.kde.org/r/2642/diff


Testing
-------

I'm using it loacaly in my videoshape and it works.
Not all means of creating a store will currently result in a valid url returned from \
filenameOfStore() but this is hinted at in the documentation.


Thanks,

Casper

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]