[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Loading and saving of custom path data for
From:       "Jan Hambrecht" <jaham () gmx ! net>
Date:       2010-01-19 19:10:35
Message-ID: 20100119191035.13673.74006 () localhost
[Download RAW message or body]



> On 2010-01-17 06:29:19, Thorsten Zachmann wrote:
> > I have a problem with the connectors saved here: 
> > http://www.zagge.de/files/connector.odp
> > On saving it looked like this:
> > http://www.zagge.de/files/connector.png
> > 
> > OpenOffice 3.1 does not show any connectors that are not fully connected.

That is because I only used the loaded path data when not connected at all. When \
trying to implement it also for partly connected ones, I found out that it is a much \
more complex problem as the connected shapes might be loaded at a later point in \
time. This means at the time of loading the connector, not all required information \
is avalilable. I have to think a little more about that and how to solve it cleanly.


> On 2010-01-17 06:29:19, Thorsten Zachmann wrote:
> > /trunk/koffice/libs/flake/KoConnectionShape.cpp, line 293
> > <http://reviewboard.kde.org/r/2634/diff/1/?file=17192#file17192line293>
> > 
> > I think the path can be saved in all cases. This should limit problems where 2 \
> > different suites calculate a different \
> > path.http://www.zagge.de/files/connector.png

Yeah that might be a good idea. But if OOo is not loading it anyway, there is not \
much value in that (yet).


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2634/#review3728
-----------------------------------------------------------


On 2010-01-16 12:58:01, Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2634/
> -----------------------------------------------------------
> 
> (Updated 2010-01-16 12:58:01)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch implements loading and saving of path data of a connector shape as \
> defined by ODF 1.2. Connector shapes not connected completely with both ends of the \
> connector to an existing shape can preserve their path data by saving it to a svg:d \
> attribute plus an additional svg:viewBox attribute. The exact details are properly \
> underdefined in the ODF specification, as usual. I implemented it the way which \
> made most sense to me. Note that OOo seems to not save the requiered svg:viewBox \
> attribute, but the code does deal with that case sufficiently. In order to reuse \
> some existing code from KoPathShape I moved the private KoPathShape::map function \
> to the shared Private class. Also I added a default parameter value to the \
> KoPathShape::toString function as it seems in most cases a identiy matrix was \
> passed anyway. 
> 
> Diffs
> -----
> 
> /trunk/koffice/libs/flake/KoConnectionShape.cpp 1075269 
> /trunk/koffice/libs/flake/KoConnectionShape_p.h 1075269 
> /trunk/koffice/libs/flake/KoPathShape.h 1075269 
> /trunk/koffice/libs/flake/KoPathShape.cpp 1075269 
> /trunk/koffice/libs/flake/KoPathShape_p.h 1075269 
> 
> Diff: http://reviewboard.kde.org/r/2634/diff
> 
> 
> Testing
> -------
> 
> I tested with an OOo exported odp file which contained 3 different unconnected \
> connector shapes. The additional saved attributes do validate when checking with \
> the online ODF validator (there are some errors thrown from other \
> elements/attributes in our files, which do show some errors on the validator side, \
> i.e. regarding draw:layer-set element). 
> 
> Thanks,
> 
> Jan
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]