[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Concerning automated astyle application to the code
From:       "C. Boemann" <cbo () boemann ! dk>
Date:       2010-01-17 20:16:23
Message-ID: 201001172116.24057.cbo () boemann ! dk
[Download RAW message or body]

On Sunday 17 January 2010 21:12:00 Dmitry Kazakov wrote:
> On Sun, Jan 17, 2010 at 10:54 PM, C. Boemann <> wrote:
> > I actually prefer the new look of that code
> 
> Why did it add doubled amount of spaces(8) for the next 
indentation level?
> 
because those are extra arguments so the different indentation 
puts it apart from the code

> > On Sunday 17 January 2010 20:53:44 Dmitry Kazakov wrote:
> > > Hi, All!
> > >
> > > I know it is good to keep the code in a good consistent 
style.
> >
> > But here is
> >
> > >  a piece of code, changed by automated astyle commit:
> > >
> > >
> > > KisPaintDeviceSP KisGroupLayer::tryObligeChild() const
> > > {
> > >     KisPaintDeviceSP retval;
> > >
> > >     if (parent().isNull() && childCount() == 1) {
> > >         const KisLayer *child =
> > > dynamic_cast<KisLayer*>(firstChild().data());
> > >
> > >         if (child &&
> > >                 child->channelFlags().isEmpty() &&
> > >                 child->projection() &&
> > >                 child->visible() &&
> > >                 child->opacity() == OPACITY_OPAQUE &&
> > >                 *child->projection()->colorSpace() ==
> >
> > *colorSpace()) {
> >
> > >             retval = child->projection();
> > >         }
> > >     }
> > >
> > >     return retval;
> > > }
> > >
> > > In original it looked quite pretty:
> > >
> > > KisPaintDeviceSP KisGroupLayer::tryObligeChild() const
> > > {
> > >     KisPaintDeviceSP retval;
> > >
> > >     if (parent().isNull() && childCount() == 1) {
> > >         const KisLayer *child =
> > > dynamic_cast<KisLayer*>(firstChild().data());
> > >
> > >         if (child &&
> > >             child->channelFlags().isEmpty() &&
> > >             child->projection() &&
> > >             child->visible() &&
> > >             child->opacity() == OPACITY_OPAQUE &&
> > >             *child->projection()->colorSpace() == 
*colorSpace()) {
> > >
> > >             retval = child->projection();
> > >         }
> > >     }
> > >
> > >     return retval;
> > > }
> > >
> > > So should we report to astyle developers or change some
> >
> > options?
> >
> > _______________________________________________
> > koffice-devel mailing list
> > koffice-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/koffice-devel
> 
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]