[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Concerning automated astyle application to the code
From:       "C. Boemann" <cbo () boemann ! dk>
Date:       2010-01-17 19:54:03
Message-ID: 201001172054.03296.cbo () boemann ! dk
[Download RAW message or body]

I actually prefer the new look of that code

On Sunday 17 January 2010 20:53:44 Dmitry Kazakov wrote:
> Hi, All!
> 
> I know it is good to keep the code in a good consistent style. 
But here is
>  a piece of code, changed by automated astyle commit:
> 
> 
> KisPaintDeviceSP KisGroupLayer::tryObligeChild() const
> {
>     KisPaintDeviceSP retval;
> 
>     if (parent().isNull() && childCount() == 1) {
>         const KisLayer *child =
> dynamic_cast<KisLayer*>(firstChild().data());
> 
>         if (child &&
>                 child->channelFlags().isEmpty() &&
>                 child->projection() &&
>                 child->visible() &&
>                 child->opacity() == OPACITY_OPAQUE &&
>                 *child->projection()->colorSpace() == 
*colorSpace()) {
> 
>             retval = child->projection();
>         }
>     }
> 
>     return retval;
> }
> 
> In original it looked quite pretty:
> 
> KisPaintDeviceSP KisGroupLayer::tryObligeChild() const
> {
>     KisPaintDeviceSP retval;
> 
>     if (parent().isNull() && childCount() == 1) {
>         const KisLayer *child =
> dynamic_cast<KisLayer*>(firstChild().data());
> 
>         if (child &&
>             child->channelFlags().isEmpty() &&
>             child->projection() &&
>             child->visible() &&
>             child->opacity() == OPACITY_OPAQUE &&
>             *child->projection()->colorSpace() == *colorSpace()) {
> 
>             retval = child->projection();
>         }
>     }
> 
>     return retval;
> }
> 
> So should we report to astyle developers or change some 
options?
> 
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]