[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Rendering of filter effects applied to groups
From:       jaham () gmx ! net
Date:       2010-01-17 15:23:53
Message-ID: 201001171623.53589.jaham () gmx ! net
[Download RAW message or body]

On Sunday 17 January 2010 07:41:48 Thorsten Zachmann wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2540/#review3730
> -----------------------------------------------------------
> 
> >>From looking a the code how groups are painted there might be a bug that
> >> hidden shapes get painted when they are in a group where are shapes that
> >> are not hidden. The group gets added for painting and then later in
> >> paintGroup it is not checked if the child of the group is hidden. As I
> >> have not tested the patch I might be wrong on that one.

Indeed that check was missing, good catch!

Ciao Jan
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]