[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Use BoundingBoxMode for gradients
From:       "Jan Hambrecht" <jaham () gmx ! net>
Date:       2010-01-13 19:18:48
Message-ID: 20100113191848.25158.6515 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2527/#review3682
-----------------------------------------------------------

Ship it!


- Jan


On 2010-01-13 06:53:28, Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2527/
> -----------------------------------------------------------
> 
> (Updated 2010-01-13 06:53:28)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> The patch changes gradients to use the BoundingBoxMode. This change 
> makes it possible to remove some special code that is needed at the moment 
> when resizing a shape. It adds support for loading gradients that are saved in 
> percent values. When saving in odf always objectBoundingBox is used as that is 
> the only one supported by odf. For svg also userSpaceOnUse is supported.
> 
> It might also make it possible to share the gradients between the shapes. 
> However that is not addressed yet.
> 
> Please have a look at the patch and most importantly on the svg part. It 
> should be fine but I might have missed something.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/filters/karbon/svg/SvgGradientHelper.h 1073389 
>   trunk/koffice/filters/karbon/svg/SvgGradientHelper.cpp 1073389 
>   trunk/koffice/filters/karbon/svg/SvgParser.cpp 1073389 
>   trunk/koffice/filters/karbon/svg/svgexport.cc 1073389 
>   trunk/koffice/karbon/common/KarbonGradientHelper.h 1073389 
>   trunk/koffice/karbon/common/KarbonGradientHelper.cpp 1073389 
>   trunk/koffice/karbon/plugins/tools/KarbonGradientEditStrategy.h 1073389 
>   trunk/koffice/karbon/plugins/tools/KarbonGradientEditStrategy.cpp 1073389 
>   trunk/koffice/karbon/plugins/tools/KarbonGradientTool.cpp 1073389 
>   trunk/koffice/karbon/ui/widgets/KarbonSmallStylePreview.cpp 1073389 
>   trunk/koffice/libs/flake/KoFlake.h 1073389 
>   trunk/koffice/libs/flake/KoFlake.cpp 1073389 
>   trunk/koffice/libs/flake/KoGradientBackground.cpp 1073389 
>   trunk/koffice/libs/flake/KoShape.cpp 1073389 
>   trunk/koffice/libs/odf/KoOdfGraphicStyles.cpp 1073389 
>   trunk/koffice/plugins/dockers/styledocker/StyleDocker.cpp 1073389 
>   trunk/koffice/plugins/pathshapes/ellipse/EllipseShapeFactory.cpp 1073389 
>   trunk/koffice/plugins/pathshapes/rectangle/RectangleShapeFactory.cpp 1073389 
> 
> Diff: http://reviewboard.kde.org/r/2527/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thorsten
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]