[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Support for sections
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-01-13 8:49:59
Message-ID: 20100113084959.10611.3684 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2546/#review3678
-----------------------------------------------------------


Ideally komain and kowidgets doe not depend on kotext, so I think the KoPageLayout \
(and the columns too) should be moved to libodf instead.

Approach seems fine to me so far.


trunk/koffice/libs/kotext/styles/KoSectionStyle.h
<http://reviewboard.kde.org/r/2546/#comment3032>

    this should probably be const.



trunk/koffice/libs/kotext/styles/KoSectionStyle.h
<http://reviewboard.kde.org/r/2546/#comment3033>

    I think that since 'indent' is about text and a frame doesn't (just) hold text \
this property should not be here at all. So its good to ifdef that out ;)



trunk/koffice/libs/kotext/styles/KoSectionStyle.h
<http://reviewboard.kde.org/r/2546/#comment3035>

    Ideally all those should be on the private object so they don't show up in the \
public API.


- Thomas


On 2010-01-11 00:16:50, Casper Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2546/
> -----------------------------------------------------------
> 
> (Updated 2010-01-11 00:16:50)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This is the first step into supporting sections in kotext
> 
> Sections are loaded into QTextFrame.
> 
> The corresponding section styles should be loaded into KoSectionStyle
> 
> As part of this the struct KoColumns from widgets/KoPageLayout is moved to kotext, \
> into a headerfile of it's own 
> This patch currently doesn't load the styles yet, but the text is placed inside \
> frames. 
> I'm thus only looking for review so far, and not an approval
> 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/kotext/CMakeLists.txt 1072623 
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1072623 
> trunk/koffice/libs/kotext/styles/KoColumns.h PRE-CREATION 
> trunk/koffice/libs/kotext/styles/KoSectionStyle.h PRE-CREATION 
> trunk/koffice/libs/kotext/styles/KoSectionStyle.cpp PRE-CREATION 
> trunk/koffice/libs/widgets/KoPageLayout.h 1072623 
> 
> Diff: http://reviewboard.kde.org/r/2546/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Casper
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]