[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Kpresentation : Filter added support for header
From:       Jos van den Oever <Jos.van.den.Oever () kogmbh ! com>
Date:       2010-01-11 11:00:11
Message-ID: 201001111200.11769.Jos.van.den.Oever () kogmbh ! com
[Download RAW message or body]

On Monday 11 January 2010 11:40:22 Amit Aggarwal wrote:
> Yes It will not footer and date when it is not needed. Bcoz in content.xml
>  there is style attribute display-footer-name:- true or false.By which we
>  can control the display.
> 
> Sure once i will get time i will add the +ve -ve tests.

Ok, my acceptance of the patch depends on such tests.
 
> > On 2010-01-11 07:48:14, vandenoever wrote:
> > > trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc,
> > > line 292
> > > <http://reviewboard.kde.org/r/2484/diff/3/?file=16783#file16783line292>
> > >
> > >     Why are you using hard-coded numbers here? Please add an
> > > explanation comment.
> 
> I saw in spec and no where I am able to find the frame size for footer .
>  Let me knw how can i get it.
Can you take a bit more time to write proper English? That sentence does not 
make sense.
You are writing the patch and I assume you know how and why you get these 
numbers. Where in the spec are they? Please add a reference to the place where 
you got these numbers a comment in the code.

> > On 2010-01-11 07:48:14, vandenoever wrote:
> > > trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc,
> > > line 301
> > > <http://reviewboard.kde.org/r/2484/diff/3/?file=16783#file16783line301>
> > >
> > >     Same point, please explain the hard-coded numbers.
> 
> This is the same as I havent seen any cordinate related info in
>  headerfooterAtom.
Then please look for it. Hard-coding numbers that make one particular file 
render well does not help improving the filters.

Cheers,
Jos

-- 
Jos van den Oever
+49 391 25 19 15 53
http://kogmbh.com/legal/
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]