[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Rendering of filter effects applied to groups
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-01-10 19:12:51
Message-ID: 20100110191251.22948.86102 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2540/#review3638
-----------------------------------------------------------


Great work, I think I found one serious issue, the rest is minor.


/trunk/koffice/libs/flake/KoFilterEffectStack.h
<http://reviewboard.kde.org/r/2540/#comment2966>

    that 'return' line looks inverted.
    also a english grammer issue; its "otherwise false" not "else"



/trunk/koffice/libs/flake/KoShapeManager.cpp
<http://reviewboard.kde.org/r/2540/#comment2967>

    Recursivly is not a word ;)
    You might want to write "paints recursive"...



/trunk/koffice/libs/flake/KoShapeManager.cpp
<http://reviewboard.kde.org/r/2540/#comment2969>

    I would suggest to name it "paintGroup".  That this is recursive should be \
evident then.



/trunk/koffice/libs/flake/KoShapeManager.cpp
<http://reviewboard.kde.org/r/2540/#comment2970>

    If a shape is not 'clipped' to its parent then painting the parent won't paint \
the child.  Do I understand this change correct that unclipped shapes with a filter \
applied to the parent would stop being painted?



/trunk/koffice/libs/flake/KoShapeManager.cpp
<http://reviewboard.kde.org/r/2540/#comment2971>

    minor coding style; space before the opening curly-brace please. :)


- Thomas


On 2010-01-10 16:43:03, Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2540/
> -----------------------------------------------------------
> 
> (Updated 2010-01-10 16:43:03)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Shapes with an ancestor which has filter effects applied will not be painted on its \
> own anymore, instead the ancestor shape is painted recursively. This allows the \
> filter effects to be applied to all children of a group shape at once. 
> 
> Diffs
> -----
> 
> /trunk/koffice/libs/flake/KoFilterEffectStack.h 1072601 
> /trunk/koffice/libs/flake/KoFilterEffectStack.cpp 1072601 
> /trunk/koffice/libs/flake/KoShapeManager.cpp 1072601 
> 
> Diff: http://reviewboard.kde.org/r/2540/diff
> 
> 
> Testing
> -------
> 
> I tested with a sample document from the svg test suite (filters-example-01-b.svg)
> 
> 
> Thanks,
> 
> Jan
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]