[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: kotext: use QString::isEmpty() + minor
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-01-09 8:23:31
Message-ID: 20100109082331.29909.8956 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2525/#review3608
-----------------------------------------------------------

Ship it!


Looks fine to me.

- Thomas


On 2010-01-08 21:07:22, Jaroslaw Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2525/
> -----------------------------------------------------------
> 
> (Updated 2010-01-08 21:07:22)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> - use QString::isEmpty() (safer) instead of isNull()
> - optimizations of returned values
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/libs/kotext/KoTextDebug.cpp 1071271 
>   /trunk/koffice/libs/kotext/kohyphen/kohyphen.cpp 1071271 
>   /trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp 1071271 
>   /trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1071271 
>   /trunk/koffice/libs/kotext/styles/KoTableCellStyle.cpp 1071271 
>   /trunk/koffice/libs/kotext/styles/KoTableColumnStyle.cpp 1071271 
>   /trunk/koffice/libs/kotext/styles/KoTableFormat.cpp 1071271 
>   /trunk/koffice/libs/kotext/styles/KoTableRowStyle.cpp 1071271 
>   /trunk/koffice/libs/kotext/styles/KoTableStyle.cpp 1071271 
> 
> Diff: http://reviewboard.kde.org/r/2525/diff
> 
> 
> Testing
> -------
> 
> unit tests pass; there's a rule that if isNull() is true, isEmpty() is also true. 
> Changes are trivial.
> 
> 
> Thanks,
> 
> Jaroslaw
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]