[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: added selection icons
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2010-01-07 18:24:16
Message-ID: 20100107182416.32667.60980 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2522/#review3600
-----------------------------------------------------------


The correct way of getting the icons into your application is to use KIcon, like \
KIcon("bla") -- it doesn't matter it seems whether or not you add the .png suffix. If \
you set the icon on a button in Qt Designer, it won't be themable anymore, so it is \
correct to set the icons from the code, as far as I know.

- Boudewijn


On 2010-01-07 12:29:20, Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2522/
> -----------------------------------------------------------
> 
> (Updated 2010-01-07 12:29:20)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> I don't know, how to add the icons into the ui file and i'm unsure, if that's the \
> right way to add them in source. 
> kis_selection_options.cc is the important file.
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/krita/pics/CMakeLists.txt 1070832 
> /trunk/koffice/krita/pics/select_pixel.png UNKNOWN 
> /trunk/koffice/krita/pics/select_shape.png UNKNOWN 
> /trunk/koffice/krita/pics/selection_add.png UNKNOWN 
> /trunk/koffice/krita/pics/selection_exclude.png UNKNOWN 
> /trunk/koffice/krita/pics/selection_intersect.png UNKNOWN 
> /trunk/koffice/krita/pics/selection_replace.png UNKNOWN 
> /trunk/koffice/krita/pics/selection_subtract.png UNKNOWN 
> /trunk/koffice/krita/ui/forms/wdgselectionoptions.ui 1070832 
> /trunk/koffice/krita/ui/tool/kis_selection_options.cc 1070832 
> 
> Diff: http://reviewboard.kde.org/r/2522/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Adam
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]