[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: polygon, ellipse and rectangle tool base class
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2010-01-05 10:09:04
Message-ID: 20100105100904.25914.69827 () localhost
[Download RAW message or body]



> On 2010-01-05 07:54:35, Boudewijn Rempt wrote:
> > Looks good. The menu issue is caused by the implementation of the right-click \
> > menu in the canvas. I'm not sure how to solve it. As far as I'm concerned, feel \
> > free to replace the Esc shortcut in kis_view2.cpp with ctrl-h (I can rebind it \
> > for my own usage :-). In that case, you can also remove the comment: 
> > // Note: do not change the default shortcut to something else, like ctrl-h. The \
> > escape // key is the only one available on tablet pc's in tablet mode, and that's \
> > when this // feature is most useful.
> > m_d->toggleDockers->setShortcut(QKeySequence(Qt::Key_Escape));
> > 
> > I haven't got time now to investigate whether we can disable the right-click menu \
> > for some tools, but we can put that on the todo list. I'm fine with committing \
> > this patch before that is done.

Btw, it would be nice put a spacer under the widgets in the tool option widget, so \
they don't spread out if the widget is made larger.


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2500/#review3578
-----------------------------------------------------------


On 2010-01-04 22:11:02, Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2500/
> -----------------------------------------------------------
> 
> (Updated 2010-01-04 22:11:02)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> moved polygon, ellipse and rectangle tools to a base class, so that they can be \
> reused in selection tools. that fixed some bugs and i will try to improve the \
> usability further.  
> issues:
> * while dragging, a right click opens the menu. cancelling the tool would be \
>                 better, but i don't know, how to achieve this.
> * the Escape key needs to be rebound, so that the tools can use it for cancelling.
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_ellipse.h 1070104 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_ellipse.cc 1070104 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_rectangle.h 1070104 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_rectangle.cc 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/CMakeLists.txt 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_contiguous.h \
>                 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_contiguous.cc \
>                 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_elliptical.h \
>                 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_elliptical.cc \
>                 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_outline.cc \
>                 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_path.h 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_path.cc 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_polygonal.h \
>                 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_polygonal.cc \
>                 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_rectangular.h \
>                 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_rectangular.cc \
>                 1070104 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_similar.cc \
>                 1070104 
> /trunk/koffice/krita/plugins/tools/tool_polygon/kis_tool_polygon.h 1070104 
> /trunk/koffice/krita/plugins/tools/tool_polygon/kis_tool_polygon.cc 1070104 
> /trunk/koffice/krita/ui/CMakeLists.txt 1070104 
> /trunk/koffice/krita/ui/canvas/kis_canvas2.h 1070104 
> /trunk/koffice/krita/ui/tool/kis_tool_ellipse_base.h PRE-CREATION 
> /trunk/koffice/krita/ui/tool/kis_tool_ellipse_base.cpp PRE-CREATION 
> /trunk/koffice/krita/ui/tool/kis_tool_polygon_base.h PRE-CREATION 
> /trunk/koffice/krita/ui/tool/kis_tool_polygon_base.cpp PRE-CREATION 
> /trunk/koffice/krita/ui/tool/kis_tool_rectangle_base.h PRE-CREATION 
> /trunk/koffice/krita/ui/tool/kis_tool_rectangle_base.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/2500/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Adam
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]