[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Table Of Content, first step.
From:       "Pierre Ducroquet" <pinaraf () pinaraf ! info>
Date:       2010-01-03 20:17:02
Message-ID: 20100103201702.12080.95520 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2410/#review3563
-----------------------------------------------------------


Ok, I found two simple problems with your code that have to be fixed...


/trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp
<http://reviewboard.kde.org/r/2410/#comment2825>

    Problem with this line : what is 80200 ?? Why not 42 ?



/trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp
<http://reviewboard.kde.org/r/2410/#comment2826>

    An index-title node can contain one or more text-content element (ODF spec 1.1 \
paragraphs 2.3.1 and 7.2:3), so this code is not correct, it should rather call \
something like loadBody


- Pierre


On 2010-01-03 18:37:30, Jean-Nicolas Artaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2410/
> -----------------------------------------------------------
> 
> (Updated 2010-01-03 18:37:30)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Hello,
> 
> As you know, I work on the Table of Content (ToC) I've begining by making it 
> displayable when you load a ToC in a file. Here is my result :
> 
> a ToC created in OOo writer : http://img20.imageshack.us/img20/8933/tocooo.png
> a ToC opened in KWord : http://img695.imageshack.us/img695/9203/tockoffice.png
> 
> As I said, ToC are not yet noted ToC in the code, just as normal paragraphs.
> It is a good beginning to have it displayed than nothing.
> btw, you can edit it as normal texts.
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/libs/kotext/opendocument/KoTextLoader.h 1069531 
> /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1069531 
> /trunk/koffice/libs/kotext/opendocument/KoTextWriter.h 1069531 
> /trunk/koffice/libs/kotext/opendocument/KoTextWriter.cpp 1069531 
> /trunk/koffice/plugins/textshape/Layout.cpp 1069531 
> 
> Diff: http://reviewboard.kde.org/r/2410/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jean-Nicolas
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]