[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Kpresenter not displaying footer.
From:       "Amit Aggarwal" <amitcs06 () gmail ! com>
Date:       2009-12-30 8:06:09
Message-ID: 20091230080609.14358.96748 () localhost
[Download RAW message or body]



> On 2009-12-30 06:34:45, Thorsten Zachmann wrote:
> > The way used here to reach the result goes in the wrong direction. The \
> > <presentation:footer/> should be handled as variable like e.g. \
> > <text:page-number>. 
> > With going that way only a variable plugin needs to be added.
> > 
> > Your patch looses the value of the variable on saving.
> > 
> > Please refrain from adding function to KoShape which are only needed by one \
> > shape. 
> > If you need help changing the patch to use variables please send me a mail?

No actually the problem is that in styles.xml we are reprsenting presentation:footer \
which is drawn in case of loadMasterPage. 

But while loading pages we are use-footer-name

<presentation:header-decl presentation:name="hdr1">header</presentation:header-decl>
<presentation:footer-decl presentation:name="ftr1">Footer for the \
slide</presentation:footer-decl> <presentation:footer-decl \
presentation:name="ftr2">footer</presentation:footer-decl> \
<presentation:date-time-decl presentation:name="dtd1" \
presentation:source="current-date" style:data-style-name="D3"/> ?
<draw:page draw:name="Slide 1" draw:style-name="dp1" draw:master-page-name="Default" \
presentation:presentation-page-layout-name="AL1T0" \
presentation:use-footer-name="ftr1" presentation:use-date-time-name="dtd1">

Like that . So cant do in opposite way that data of footer will display while loading \
loadMasterPages. As in every page we are reading the footer decl via use-footer-name.


> On 2009-12-30 06:34:45, Thorsten Zachmann wrote:
> > trunk/koffice/libs/odf/KoOdfStylesReader.h, line 51
> > <http://reviewboard.kde.org/r/2457/diff/2/?file=16223#file16223line51>
> > 
> > The header/footer declarations are no styles therefore they should not be saved \
> > inside KoOdfStyleReader.  The best place to store would be the application.

This thing is still not clear 
<presentation:header-decl presentation:name="hdr1">header</presentation:header-decl>
<presentation:footer-decl presentation:name="ftr1">Footer for the \
slide</presentation:footer-decl> <presentation:footer-decl \
presentation:name="ftr2">footer</presentation:footer-decl>


If it is not decl style than plz suggest me which is the god place to store it. 

But in our content.xml while drwaing every page we are using use-footer-name to read \
the footer-decl So I considered it as decl-styles. 


- Amit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2457/#review3525
-----------------------------------------------------------


On 2009-12-29 12:47:17, Amit Aggarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2457/
> -----------------------------------------------------------
> 
> (Updated 2009-12-29 12:47:17)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> 1) As presentation:footer or header frame is not containing text in styles.xml so \
> kpresenter is not disaplying the text. 
> Changes:- 
> 1) Reading decl-styles from content.xml office:body
> 2) Added decl styles into declstyles.
> 2) Pointer of the footer frame is used to display the text for the already framed \
> draw. 
> 
> Diffs
> -----
> 
> trunk/koffice/plugins/textshape/TextShape.h 1067316 
> trunk/koffice/plugins/textshape/TextShape.cpp 1067316 
> trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp 1067316 
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1067316 
> trunk/koffice/libs/odf/KoOdfLoadingContext.cpp 1067316 
> trunk/koffice/libs/odf/KoOdfStylesReader.cpp 1067316 
> trunk/koffice/libs/odf/KoOdfReadStore.cpp 1067316 
> trunk/koffice/libs/odf/KoOdfStylesReader.h 1067316 
> trunk/koffice/kpresenter/part/KPrDocument.cpp 1067316 
> trunk/koffice/kpresenter/part/KPrPage.h 1067316 
> trunk/koffice/kpresenter/part/KPrPage.cpp 1067316 
> trunk/koffice/libs/flake/KoShape.h 1067316 
> trunk/koffice/libs/flake/KoShape.cpp 1067316 
> trunk/koffice/libs/flake/KoShapeLoadingContext.h 1067316 
> trunk/koffice/libs/flake/KoShapeLoadingContext.cpp 1067316 
> trunk/koffice/libs/flake/KoShapeRegistry.cpp 1067316 
> trunk/koffice/libs/kopageapp/KoPADocument.h 1067316 
> trunk/koffice/libs/kopageapp/KoPADocument.cpp 1067316 
> trunk/koffice/libs/kopageapp/KoPAPage.cpp 1067316 
> trunk/koffice/libs/kopageapp/KoPAPageBase.cpp 1067316 
> trunk/koffice/libs/kotext/KoVariableRegistry.cpp 1067316 
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1067316 
> trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp 1067316 
> trunk/koffice/kpresenter/part/KPrDocument.h 1067316 
> 
> Diff: http://reviewboard.kde.org/r/2457/diff
> 
> 
> Testing
> -------
> 
> Tested on different odp files. 
> 
> 
> Thanks,
> 
> Amit
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]