[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Kpresenter not displaying footer.
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2009-12-29 13:01:20
Message-ID: 20091229130120.23505.27551 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2457/#review3522
-----------------------------------------------------------


Looks good in general, but:

1. I don't understand what you are trying to do.  Can you give a reference to the \
spec or a usecase? 2. There are too many enabled kdebug()s.  It will be very noicy \
when it runs, I suggest commenting most of them away before committing. I also saw \
some places where you used different numbers to kdebug in the same file. 3. Still \
some style issues like "if(" instead of "if (" and whitespace at end of lines.  They \
should be easy to find since they are marked red.

- Inge


On 2009-12-29 12:47:17, Amit Aggarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2457/
> -----------------------------------------------------------
> 
> (Updated 2009-12-29 12:47:17)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> 1) As presentation:footer or header frame is not containing text in styles.xml so \
> kpresenter is not disaplying the text. 
> Changes:- 
> 1) Reading decl-styles from content.xml office:body
> 2) Added decl styles into declstyles.
> 2) Pointer of the footer frame is used to display the text for the already framed \
> draw. 
> 
> Diffs
> -----
> 
> trunk/koffice/plugins/textshape/TextShape.h 1067316 
> trunk/koffice/plugins/textshape/TextShape.cpp 1067316 
> trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp 1067316 
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1067316 
> trunk/koffice/libs/odf/KoOdfLoadingContext.cpp 1067316 
> trunk/koffice/libs/odf/KoOdfStylesReader.cpp 1067316 
> trunk/koffice/libs/odf/KoOdfReadStore.cpp 1067316 
> trunk/koffice/libs/odf/KoOdfStylesReader.h 1067316 
> trunk/koffice/kpresenter/part/KPrDocument.cpp 1067316 
> trunk/koffice/kpresenter/part/KPrPage.h 1067316 
> trunk/koffice/kpresenter/part/KPrPage.cpp 1067316 
> trunk/koffice/libs/flake/KoShape.h 1067316 
> trunk/koffice/libs/flake/KoShape.cpp 1067316 
> trunk/koffice/libs/flake/KoShapeLoadingContext.h 1067316 
> trunk/koffice/libs/flake/KoShapeLoadingContext.cpp 1067316 
> trunk/koffice/libs/flake/KoShapeRegistry.cpp 1067316 
> trunk/koffice/libs/kopageapp/KoPADocument.h 1067316 
> trunk/koffice/libs/kopageapp/KoPADocument.cpp 1067316 
> trunk/koffice/libs/kopageapp/KoPAPage.cpp 1067316 
> trunk/koffice/libs/kopageapp/KoPAPageBase.cpp 1067316 
> trunk/koffice/libs/kotext/KoVariableRegistry.cpp 1067316 
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1067316 
> trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp 1067316 
> trunk/koffice/kpresenter/part/KPrDocument.h 1067316 
> 
> Diff: http://reviewboard.kde.org/r/2457/diff
> 
> 
> Testing
> -------
> 
> Tested on different odp files. 
> 
> 
> Thanks,
> 
> Amit
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]