-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2309/#review3516
-----------------------------------------------------------

Ship it!


Looks good.

I haven't checked the code, but if there isn't already, there should probably also be default values for the padding.  Maybe adding default padding would have to change the values for the default margin to still look good.

- Inge


On 2009-12-12 17:14:03, Mani Chandrasekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2309/
> -----------------------------------------------------------
> 
> (Updated 2009-12-12 17:14:03)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> I have two minor changes,
> 1.Set the default margin width to be 20mm. Text starts from top of the page with out any margin, If only left & right margin are defined.
> 
> 2.Paragraph borders start from the text indent position. Calculating the border rect position 
> 
> I would propose to use KoBorder instead of KoTextBlockBorderData class. As this class is reimplementation of KoBorder data. Any comments ? 
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/libs/widgets/KoPageLayout.cpp 1054516 
>   trunk/koffice/plugins/textshape/Layout.cpp 1054516 
> 
> Diff: http://reviewboard.kde.org/r/2309/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> KWord
>   http://reviewboard.kde.org/r/2309/s/277/
> OoWriter
>   http://reviewboard.kde.org/r/2309/s/278/
> Abiword converted to PDF using officeshot
>   http://reviewboard.kde.org/r/2309/s/279/
> 
> 
> Thanks,
> 
> Mani
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel