[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Kpresenter:MS2003:Bullet number is not working
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2009-12-23 23:09:47
Message-ID: 20091223230947.23953.59273 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2445/#review3503
-----------------------------------------------------------


The part that I could read looked good.  But there were two C++ files where the patch \
didn't apply to the current source code.  I think you need to check that when you \
enter a patch. So you have to upload a new version of the patch that works.

The parts that contained only removal of trailing whitespace can be applied \
immediately.

- Inge


On 2009-12-23 05:12:01, Amit Aggarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2445/
> -----------------------------------------------------------
> 
> (Updated 2009-12-23 05:12:01)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> 1) Added changes to read the pf9 autoscheme for the bullet.
> 2) Added style to display the bullet in content.xml
> 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kpresenter/powerpoint/import/datetimeformat.h 1065338 
> trunk/koffice/filters/kpresenter/powerpoint/import/datetimeformat.cc 1065338 
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h 1065338 
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1065338 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.h 1065338 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp 1065338 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.cpp 1065338 
> 
> Diff: http://reviewboard.kde.org/r/2445/diff
> 
> 
> Testing
> -------
> 
> Tested on different documents
> 
> 
> Thanks,
> 
> Amit
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]