From koffice-devel  Tue Dec 22 13:10:31 2009
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: Tue, 22 Dec 2009 13:10:31 +0000
To: koffice-devel
Subject: Re: Review Request: kpresenter:MS2003 ppt :Date is not getting
Message-Id: <20091222131031.19449.65329 () localhost>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=126148742820354


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2394/#review3477
-----------------------------------------------------------

Ship it!


Looks good, except for a few formatting issues.  I'll commit it for you with those formatting issues fixed.

- Inge


On 2009-12-17 11:33:02, Amit Aggarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2394/
> -----------------------------------------------------------
> 
> (Updated 2009-12-17 11:33:02)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> 1) Added missing Atom.
> 2) Parse the date time field and formatId
> 3) Added corresponding styles in style and content.xml
> 4) Created new files for the different date and time formats.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/filters/kpresenter/powerpoint/import/CMakeLists.txt 1063192 
>   trunk/koffice/filters/kpresenter/powerpoint/import/datetimeformat.h PRE-CREATION 
>   trunk/koffice/filters/kpresenter/powerpoint/import/datetimeformat.cc PRE-CREATION 
>   trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h 1063192 
>   trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1063192 
>   trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp 1063192 
>   trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.h 1063192 
>   trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.cpp 1063192 
>   trunk/koffice/libs/odf/KoGenStyle.h 1063192 
> 
> Diff: http://reviewboard.kde.org/r/2394/diff
> 
> 
> Testing
> -------
> 
> Tested with different documents.
> 
> 
> Thanks,
> 
> Amit
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel