From koffice-devel  Tue Dec 22 08:40:46 2009
From: "Cyrille Berger" <cberger () cberger ! net>
Date: Tue, 22 Dec 2009 08:40:46 +0000
To: koffice-devel
Subject: Re: Review Request: Krita: Gaussian Blur Filter
Message-Id: <20091222084046.14004.37058 () localhost>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=126147132429510


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2369/#review3476
-----------------------------------------------------------

Ship it!


I wonder about the necessity of the factor now that we use qreals. But that is something to think about it for later, I think that now it is good to go ahead and commit.

- Cyrille


On 2009-12-19 17:57:18, antiquark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2369/
> -----------------------------------------------------------
> 
> (Updated 2009-12-19 17:57:18)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch adds a real Gaussian Blur Filter (floating point kernel).
> 
> The horizontal and vertical components are computed separately (significant speed gains especially with larger radii) by performing convolution twice.
> 
> In the process a number of changes have been made:
> 
> - Convolution computation is performed using floating point numbers.
> - Kernels are defined using matrices provided by the Eigen Library.
> - Removed older 3x3 Gaussian Blur Filter.
> - Updated all other convolution filters to new system.
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/krita/image/kis_convolution_kernel.h 1063948 
>   /trunk/koffice/krita/image/kis_convolution_kernel.cc 1063948 
>   /trunk/koffice/krita/image/kis_convolution_painter_impl.h 1063948 
>   /trunk/koffice/krita/image/kis_generic_colorspace.h 1063948 
>   /trunk/koffice/krita/image/tests/kis_convolution_painter_test.cpp 1063948 
>   /trunk/koffice/krita/plugins/colorspaces/ctlcs/KoCtlConvolutionOp.h 1063948 
>   /trunk/koffice/krita/plugins/colorspaces/ctlcs/KoCtlConvolutionOp.cpp 1063948 
>   /trunk/koffice/krita/plugins/filters/blur/CMakeLists.txt 1063948 
>   /trunk/koffice/krita/plugins/filters/blur/blur.cpp 1063948 
>   /trunk/koffice/krita/plugins/filters/blur/kis_blur_filter.cpp 1063948 
>   /trunk/koffice/krita/plugins/filters/blur/kis_gaussian_blur_filter.h PRE-CREATION 
>   /trunk/koffice/krita/plugins/filters/blur/kis_gaussian_blur_filter.cpp PRE-CREATION 
>   /trunk/koffice/krita/plugins/filters/blur/kis_wdg_gaussian_blur.h PRE-CREATION 
>   /trunk/koffice/krita/plugins/filters/blur/kis_wdg_gaussian_blur.cpp PRE-CREATION 
>   /trunk/koffice/krita/plugins/filters/blur/wdg_gaussian_blur.ui PRE-CREATION 
>   /trunk/koffice/krita/plugins/filters/convolutionfilters/convolutionfilters.h 1063948 
>   /trunk/koffice/krita/plugins/filters/convolutionfilters/convolutionfilters.cpp 1063948 
>   /trunk/koffice/krita/plugins/filters/imageenhancement/kis_simple_noise_reducer.cpp 1063948 
>   /trunk/koffice/krita/plugins/filters/unsharp/kis_unsharp_filter.cpp 1063948 
>   /trunk/koffice/libs/pigment/KoColorSpace.h 1063948 
>   /trunk/koffice/libs/pigment/KoColorSpaceAbstract.h 1063948 
>   /trunk/koffice/libs/pigment/tests/TestConvolutionOpImpl.cpp 1063948 
> 
> Diff: http://reviewboard.kde.org/r/2369/diff
> 
> 
> Testing
> -------
> 
> No visible regressions.
> 
> Sometimes the filter does not work correctly (esp. with larger kernels).
> 
> 
> Thanks,
> 
> antiquark
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel