[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Fwd: Review Request: added a baseclass for all selection tools
From:       Adam <nospam () xibo ! at>
Date:       2009-12-18 17:32:51
Message-ID: op.u449oypmqw5b7d () linux-r1sx ! site
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2415/
-----------------------------------------------------------

Review request for KOffice.


Summary
-------

I added KisToolSelectBase as a base class for all selection tools and
refactored the tools in the selectiontools directory to use it. If this
patch will be accepted, I will also move KisToolSelectSimilar to the
selectiontools dir, add the new parent and implement the junior job
"implement shortcuts to switch between selection modes (add, subtract,
replace) for the Krita selection tools".

I noticed 2 bugs (crash in path select and lines not visible in polygonal,
already in the old version present), which I will also try to fix.
KisToolSelectPolygonal will need a new shortcut for deactivating.


Diffs
-----

    /trunk/./koffice/krita/plugins/tools/selectiontools/CMakeLists.txt   
1063476
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_base.h   
PRE-CREATION
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_base.cpp   
PRE-CREATION
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_contiguous.h   
1063476
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_contiguous.cc   
1063476
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_elliptical.h   
1063476
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_elliptical.cc   
1063476
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_outline.h   
1063476
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_outline.cc   
1063476
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_path.h   
1063476
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_path.cc   
1063476
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_polygonal.h   
1063476
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_polygonal.cc   
1063476
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_rectangular.h   
1063476
    /trunk/./koffice/krita/plugins/tools/selectiontools/kis_tool_select_rectangular.cc   
1063476

Diff: http://reviewboard.kde.org/r/2415/diff


Testing
-------

i've tried to use all selection tools, and they still work.


Thanks,

Adam
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]