[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Start page numbering from page 'X'
From:       Thomas Zander <zander () kde ! org>
Date:       2009-12-17 19:49:31
Message-ID: 200912172049.35317.zander () kde ! org
[Download RAW message or body]

Storing it in the page variable sounds a bit odd, KWord has pages that know 
their number, I think it should go there.

See KWPageManager::appendPage()
see line 257 in that file.  It currently hardcodes the first page to be 1.

This used to be a variable on the KWPageManager but this was removed at some 
point, not entirely sure why.
The reason is likely that the starting page number is part of the KWPageStyle 
(which represents page styles in ODF).

It would make sense to add a 'starts-at' variable to the KWPageStyle and load 
that and next make KWPageManager honor that.


On Wednesday 16. December 2009 15.57.18 Mani Chandrasekar wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2385/
> -----------------------------------------------------------
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch would give page numbering from page 'X' feature.
> 
> Correct me if I'm wrong (I really din't clearly understand ODF page
>  numbering concept)
> 
> <text:page-number text:select-page="current">2</text:page-number>
> The above tag would start the numbering from page 2 (skipping page 1)
> 
> So i have added a new variable m_startNumbering to keep track of this value
>  and saving the same value again.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1058441
>   trunk/koffice/plugins/variables/PageVariable.h 1058441
>   trunk/koffice/plugins/variables/PageVariable.cpp 1058441
> 
> Diff: http://reviewboard.kde.org/r/2385/diff
> 
> 
> Testing
> -------
> 
> Unit test passed.
> 
> 
> Thanks,
> 
> Mani
> 
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel
> 

-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]