[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/libs/flake
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2009-12-17 14:17:31
Message-ID: 200912171517.31268.t.zachmann () zagge ! de
[Download RAW message or body]

On Thursday 17 December 2009 10:24:14 Thomas Zander wrote:
> On Thursday 17. December 2009 06.18.14 Thorsten Zachmann wrote:
> > Hello Thomas,
> >
> > On Wednesday 16 December 2009 22:32:50 Thomas Zander wrote:
> > > SVN commit 1063062 by zander:
> > >
> > > Move the implementation to the d-pointer.
> > >
> > > The KoSvgPathParser and the KoPathShapeLoader were slightly
> > > overdesigned where they allowed for more parsers to be created based on
> > > the baseclass. Which never happened.
> > > Naturally, we can do that later, but for now lets clean up the API by
> > > the only two symbols that others use; the constructor and parseSvg()
> > >
> > >  M  +0 -1      CMakeLists.txt
> > >  M  +529 -34   KoPathShapeLoader.cpp
> > >  M  +16 -26    KoPathShapeLoader.h
> > >  D             KoSvgPathParser.cpp
> > >  D             KoSvgPathParser.h
> > >
> > >
> > > http://websvn.kde.org/?view=rev&revision=1063062
> >
> > Can you please discuss changes like that on the list before. This is not
> >  code you wrote and so it would be good to discuss that with the people
> >  that did. There is a other part in the code, the line ends, which will
> >  very likely use this very soon.
> 
> This was discussed with Jan and agreed on. You are not in the copyright
>  list, so I didn't talk to you, no.

Still if you would have send a mail on the list everybody could have given its 
opinion.

> If line ends starts using this baseclass it will still be inside of flake
>  so still no need to make all those symbols reverted. If the guys making
>  the lineendings stuff need something more, lets talk about it and come to
>  a good solution.
> 
> And can we please stop with the "please revert"? Its a very depressing
>  thing to say.  What about we all work together towards a BC flake (and
>  libodf) which I still hope we all want.

Then please propose changes on the list so changes can be discussed before it 
is done and create bad feelings on all sides.

> Its one thing to work alone on a BC libs, its another to get a "please
>  revert" every week and never a thank you... :(
> 
Then please bring back the base class. It won't need to be exported.

Thorsten
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]