From koffice-devel  Thu Dec 17 11:14:56 2009
From: "Amit Aggarwal" <amitcs06 () gmail ! com>
Date: Thu, 17 Dec 2009 11:14:56 +0000
To: koffice-devel
Subject: Re: Review Request: kpresenter:msoffice2003:SlideNumber is not
Message-Id: <20091217111456.17198.71769 () localhost>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=126104849432734



> On 2009-12-17 10:07:31, Inge Wallin wrote:
> > Looks good. I'll commit it for you.

ok thanks 


- Amit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2353/#review3444
-----------------------------------------------------------


On 2009-12-16 11:05:40, Amit Aggarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2353/
> -----------------------------------------------------------
> 
> (Updated 2009-12-16 11:05:40)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> SildeNumber is not getting displayed in Msoffice2003 ppt. 
> 
> Changes: - 
> 1) Added style for page-number in styles.xml
> 2) Added display-page-number attribute in content.xml
> 
> Approach used to fix:- 
> 1) Convert the ppt to odp using koconverter
> 2) Verify with is required to display the page by looking the open office odp format(styles and content)
> 3) Use MsoSchem tool to find which Atom is controlling display page number.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h 1060868 
>   trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1060868 
>   trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.h 1060868 
>   trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp 1060868 
>   trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.h 1060868 
>   trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.cpp 1060868 
> 
> Diff: http://reviewboard.kde.org/r/2353/diff
> 
> 
> Testing
> -------
> 
> Done testing with different document
> 
> 
> Thanks,
> 
> Amit
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel