[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Parse header / footer from XLS files
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2009-12-15 10:44:59
Message-ID: 20091215104459.8595.72749 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2376/#review3426
-----------------------------------------------------------

Ship it!


Good code in general!  Some small issues below, fix them and you can commit. No need \
for another round, I think.


trunk/koffice/filters/kspread/excel/import/excelimport.cc
<http://reviewboard.kde.org/r/2376/#comment2746>

    You changed the orders here between createStyles and createContent.  I know it's \
because of master slides (I asked separately), but better put a comment in here as \
well.



trunk/koffice/filters/kspread/excel/import/excelimport.cc
<http://reviewboard.kde.org/r/2376/#comment2747>

    No margin-top?



trunk/koffice/filters/kspread/excel/import/excelimport.cc
<http://reviewboard.kde.org/r/2376/#comment2748>

    No margin-bottom?



trunk/koffice/filters/kspread/excel/import/excelimport.cc
<http://reviewboard.kde.org/r/2376/#comment2744>

    Has something happened with the indentation here or is it just the web \
presentation that makes it strange?



trunk/koffice/filters/kspread/excel/import/excelimport.cc
<http://reviewboard.kde.org/r/2376/#comment2745>

    Hmm, better make some autogenerated name like "Sheet %d" with d = 1, 2, 3, ... \
instead of "???".


- Inge


On 2009-12-15 07:48:22, Mani Chandrasekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2376/
> -----------------------------------------------------------
> 
> (Updated 2009-12-15 07:48:22)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Get Header/Footer information from Xls file and save it in ODS file.
> Populating master-page from the xls file and page-layout is still dummy values.
> Modified the way styles.xml is saved, Now using KoGenStyles.
> 
> Not all Header/Footer styles are supported. (Actually i couldn't find the ODF tags \
> for some styles, But supports most of styles and custom styles) 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kspread/excel/import/excelimport.cc 1058441 
> 
> Diff: http://reviewboard.kde.org/r/2376/diff
> 
> 
> Testing
> -------
> 
> Tested with few Xls 2000/2003 formats and Unit Test passed.
> 
> 
> Thanks,
> 
> Mani
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]