[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Krita: Gaussian Blur Filter
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2009-12-14 9:59:17
Message-ID: 20091214095917.9187.8974 () localhost
[Download RAW message or body]



> On 2009-12-14 09:07:09, Boudewijn Rempt wrote:
> > Hm... I think you have forgotten to compile and run the unittests with your \
> > patch.
> 
> antiquark wrote:
> Yes, I'm applying the necessary modifications now.
> 
> Regarding the large kernel issue, I was specifically commenting about the new \
> Gaussian Blur filter. Other filters seem to be unaffected. I suspect it has \
> something to do with performing two convolutions, one after the other.

Ok -- so either we'd need to figure out what's going on, or limit the kernel size in \
the settings widget, right?


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2369/#review3416
-----------------------------------------------------------


On 2009-12-13 18:42:29, antiquark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2369/
> -----------------------------------------------------------
> 
> (Updated 2009-12-13 18:42:29)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch adds a real Gaussian Blur Filter (floating point kernel).
> 
> The horizontal and vertical components are computed separately (significant speed \
> gains especially with larger radii) by performing convolution twice. 
> In the process a number of changes have been made:
> 
> - Convolution computation is performed using floating point numbers.
> - Kernels are defined using matrices provided by the Eigen Library.
> - Removed older 3x3 Gaussian Blur Filter.
> - Updated all other convolution filters to new system.
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/krita/image/kis_convolution_kernel.h 1062071 
> /trunk/koffice/krita/image/kis_convolution_kernel.cc 1062071 
> /trunk/koffice/krita/image/kis_convolution_painter_impl.h 1062071 
> /trunk/koffice/krita/image/kis_generic_colorspace.h 1062071 
> /trunk/koffice/krita/plugins/colorspaces/ctlcs/KoCtlConvolutionOp.h 1062071 
> /trunk/koffice/krita/plugins/colorspaces/ctlcs/KoCtlConvolutionOp.cpp 1062071 
> /trunk/koffice/krita/plugins/filters/blur/CMakeLists.txt 1062071 
> /trunk/koffice/krita/plugins/filters/blur/blur.cpp 1062071 
> /trunk/koffice/krita/plugins/filters/blur/kis_blur_filter.cpp 1062071 
> /trunk/koffice/krita/plugins/filters/blur/kis_gaussian_blur_filter.h PRE-CREATION 
> /trunk/koffice/krita/plugins/filters/blur/kis_gaussian_blur_filter.cpp PRE-CREATION \
>                 
> /trunk/koffice/krita/plugins/filters/blur/kis_wdg_gaussian_blur.h PRE-CREATION 
> /trunk/koffice/krita/plugins/filters/blur/kis_wdg_gaussian_blur.cpp PRE-CREATION 
> /trunk/koffice/krita/plugins/filters/blur/wdg_gaussian_blur.ui PRE-CREATION 
> /trunk/koffice/krita/plugins/filters/convolutionfilters/convolutionfilters.h \
>                 1062071 
> /trunk/koffice/krita/plugins/filters/convolutionfilters/convolutionfilters.cpp \
>                 1062071 
> /trunk/koffice/krita/plugins/filters/imageenhancement/kis_simple_noise_reducer.cpp \
>                 1062071 
> /trunk/koffice/krita/plugins/filters/unsharp/kis_unsharp_filter.cpp 1062071 
> /trunk/koffice/libs/pigment/KoColorSpace.h 1062071 
> /trunk/koffice/libs/pigment/KoColorSpaceAbstract.h 1062071 
> 
> Diff: http://reviewboard.kde.org/r/2369/diff
> 
> 
> Testing
> -------
> 
> No visible regressions.
> 
> Sometimes the filter does not work correctly (esp. with larger kernels).
> 
> 
> Thanks,
> 
> antiquark
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]