[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: kpresenter:msoffice2003:SlideNumber is not
From: "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date: 2009-12-11 7:58:19
Message-ID: 20091211075819.1607.55650 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2353/#review3400
-----------------------------------------------------------
trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h
<http://reviewboard.kde.org/r/2353/#comment2734>
I think the function name is very missleading. It does not add a generic frame \
but a very specific one, a text frame containing the page number. Maybe you can \
update the method name accordingly or make the function more generic so it can be \
used also for other cases.
trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc
<http://reviewboard.kde.org/r/2353/#comment2735>
I think too that hard coding the style name should be avoided here. Better would \
be to pass the correct style name to the function.
trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc
<http://reviewboard.kde.org/r/2353/#comment2736>
no need to add spaces at the end :-)
- Thorsten
On 2009-12-11 05:30:57, Amit Aggarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2353/
> -----------------------------------------------------------
>
> (Updated 2009-12-11 05:30:57)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> SildeNumber is not getting displayed in Msoffice2003 ppt.
>
> Changes: -
> 1) Added style for page-number in styles.xml
> 2) Added display-page-number attribute in content.xml
>
> Approach used to fix:-
> 1) Convert the ppt to odp using koconverter
> 2) Verify with is required to display the page by looking the open office odp \
> format(styles and content) 3) Use MsoSchem tool to find which Atom is controlling \
> display page number.
>
> Diffs
> -----
>
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h 1060868
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1060868
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.h 1060868
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp 1060868
> trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.h 1060868
> trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.cpp 1060868
>
> Diff: http://reviewboard.kde.org/r/2353/diff
>
>
> Testing
> -------
>
> Done testing with different document
>
>
> Thanks,
>
> Amit
>
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic