From koffice-devel Tue Dec 01 11:19:59 2009 From: "Inge Wallin" Date: Tue, 01 Dec 2009 11:19:59 +0000 To: koffice-devel Subject: Re: Review Request: Add struct KoFontFace Message-Id: <20091201111959.13913.71536 () localhost> X-MARC-Message: https://marc.info/?l=koffice-devel&m=125966647730742 ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2257/ ----------------------------------------------------------- (Updated 2009-12-01 11:19:59.550371) Review request for KOffice. Changes ------- Third version of the patch Summary ------- Here is the first patch in a small patchset that will add filters for the MS 2007 XML file formats. Note that I am only the middle man here. This patch adds the struct KoFontFace that is a public data structure representing a font style. It is saved as a style:font-face element. Before this patch, only the font name was available, which was saved as a style:name attribute of style:font-face. Also, svg:font-family was saved as a copy. Now the old behaviour is still available but in addition, new attributes can be specified in order to make the description of a font more accurate (style:font-family-generic, svg:font-style, style:font-pitch). These are needed for increasing quality of import/export filters and is already used in the MSOOXML filters. The ODF specification offers even more attributes. The patch also contains fix for use of m_mainStyles->addFontFace() in two places, both in KWord. Diffs (updated) ----- trunk/koffice/filters/kword/msword-odf/document.cpp 1055949 trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1055949 trunk/koffice/libs/odf/CMakeLists.txt 1055949 trunk/koffice/libs/odf/KoFontFace.h PRE-CREATION trunk/koffice/libs/odf/KoFontFace.cpp PRE-CREATION trunk/koffice/libs/odf/KoGenStyles.h 1055949 trunk/koffice/libs/odf/KoGenStyles.cpp 1055949 Diff: http://reviewboard.kde.org/r/2257/diff Testing ------- Thanks, Inge _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel