'Re: Review Request: MS 2007 XML filters!'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: MS 2007 XML filters!
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2009-11-28 10:10:16
Message-ID: 20091128101016.18316.72103 () localhost
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2258/#review3319
-----------------------------------------------------------

Ship it!

Time to commit!

- Boudewijn

On 2009-11-21 12:11:26, Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2258/
> -----------------------------------------------------------
> 
> (Updated 2009-11-21 12:11:26)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Here they are: the MS 2007 filters.  (Please don't say MSOOXML, because these filters are supposed to \
> be compatible with MS Office 2007, and they don't implement the ISO standard OOXML.) 
> Note that this is a quite large patch and it only touches *one* existing file: CMakeLists.txt.  I would \
> ask to only review large problems.  The smaller ones can surely be fixed within the repository after \
> the import. 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/CMakeLists.txt 1052057 
> trunk/koffice/filters/kpresenter/CMakeLists.txt 1052057 
> trunk/koffice/filters/kpresenter/pptx/CMakeLists.txt PRE-CREATION 
> trunk/koffice/filters/kpresenter/pptx/PptxImport.h PRE-CREATION 
> trunk/koffice/filters/kpresenter/pptx/PptxImport.cpp PRE-CREATION 
> trunk/koffice/filters/kpresenter/pptx/PptxXmlDocumentReader.h PRE-CREATION 
> trunk/koffice/filters/kpresenter/pptx/PptxXmlDocumentReader.cpp PRE-CREATION 
> trunk/koffice/filters/kpresenter/pptx/PptxXmlSlideReader.h PRE-CREATION 
> trunk/koffice/filters/kpresenter/pptx/PptxXmlSlideReader.cpp PRE-CREATION 
> trunk/koffice/filters/kpresenter/pptx/README PRE-CREATION 
> trunk/koffice/filters/kpresenter/pptx/kpresenter_pptx_import.desktop PRE-CREATION 
> trunk/koffice/filters/kspread/CMakeLists.txt 1052057 
> trunk/koffice/filters/kspread/xlsx/CMakeLists.txt PRE-CREATION 
> trunk/koffice/filters/kspread/xlsx/XlsxImport.h PRE-CREATION 
> trunk/koffice/filters/kspread/xlsx/XlsxImport.cpp PRE-CREATION 
> trunk/koffice/filters/kspread/xlsx/XlsxXmlDocumentReader.h PRE-CREATION 
> trunk/koffice/filters/kspread/xlsx/XlsxXmlDocumentReader.cpp PRE-CREATION 
> trunk/koffice/filters/kspread/xlsx/XlsxXmlSharedStringsReader.h PRE-CREATION 
> trunk/koffice/filters/kspread/xlsx/XlsxXmlSharedStringsReader.cpp PRE-CREATION 
> trunk/koffice/filters/kspread/xlsx/XlsxXmlStylesReader.h PRE-CREATION 
> trunk/koffice/filters/kspread/xlsx/XlsxXmlStylesReader.cpp PRE-CREATION 
> trunk/koffice/filters/kspread/xlsx/XlsxXmlWorksheetReader.h PRE-CREATION 
> trunk/koffice/filters/kspread/xlsx/XlsxXmlWorksheetReader.cpp PRE-CREATION 
> trunk/koffice/filters/kspread/xlsx/kspread_xlsx_import.desktop PRE-CREATION 
> trunk/koffice/filters/kword/CMakeLists.txt 1052057 
> trunk/koffice/filters/kword/docx/CMakeLists.txt PRE-CREATION 
> trunk/koffice/filters/kword/docx/DocxImport.h PRE-CREATION 
> trunk/koffice/filters/kword/docx/DocxImport.cpp PRE-CREATION 
> trunk/koffice/filters/kword/docx/DocxXmlDocumentReader.h PRE-CREATION 
> trunk/koffice/filters/kword/docx/DocxXmlDocumentReader.cpp PRE-CREATION 
> trunk/koffice/filters/kword/docx/DocxXmlFontTableReader.h PRE-CREATION 
> trunk/koffice/filters/kword/docx/DocxXmlFontTableReader.cpp PRE-CREATION 
> trunk/koffice/filters/kword/docx/DocxXmlStylesReader.h PRE-CREATION 
> trunk/koffice/filters/kword/docx/DocxXmlStylesReader.cpp PRE-CREATION 
> trunk/koffice/filters/kword/docx/README PRE-CREATION 
> trunk/koffice/filters/kword/docx/kword_docx_import.desktop PRE-CREATION 
> trunk/koffice/filters/kword/msword-odf/document.cpp 1052057 
> trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1052057 
> trunk/koffice/filters/libmsooxml/CMakeLists.txt PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlCommonReader.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlCommonReader.cpp PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLMethods.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderImpl.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderMethods.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlContentTypes.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlImport.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlImport.cpp PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlReader.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlReader.cpp PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlReader_p.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlRelationships.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlRelationships.cpp PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlRelationshipsReader.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlRelationshipsReader.cpp PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlSchemas.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlThemesReader.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlThemesReader.cpp PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlUtils.h PRE-CREATION 
> trunk/koffice/filters/libmsooxml/MsooXmlUtils.cpp PRE-CREATION 
> trunk/koffice/filters/libmsooxml/msooxml_export.h PRE-CREATION 
> trunk/koffice/kpresenter/part/kpresenter.desktop 1052057 
> trunk/koffice/kpresenter/part/kpresenterpart.desktop 1052057 
> trunk/koffice/kspread/kspread.desktop 1052057 
> trunk/koffice/kspread/kspreadpart.desktop 1052057 
> trunk/koffice/kword/part/kword.desktop 1052057 
> trunk/koffice/kword/part/kwordpart.desktop 1052057 
> 
> Diff: http://reviewboard.kde.org/r/2258/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Inge
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 