[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Class KoFrameBorder for drawing borders for
From:       "Mani Chandrasekar" <maninc () gmail ! com>
Date:       2009-11-25 5:58:26
Message-ID: 20091125055826.4934.79509 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2268/
-----------------------------------------------------------

(Updated 2009-11-25 05:58:24.621623)


Review request for KOffice.


Changes
-------

Updated LGPL text (or (at your option) any later version)


Summary
-------

* Created a new class KoFrameBorder inherited from KoShapeBorderModel to handle \
                borders for Frames. This class stores style information using \
                KoBorder. 
* I have moved Paint function from KWCanvas to KoBorder, which can be used by \
                KoFrameBorder.  As it is common for both KWCanvas and KoFrameBorder. 
* Header/Footer styles are now supported. Background color/Image fill, Complex \
borders (color border and border with different width and styles). 

KoFrameBorder::fillStyle(KoGenStyle &style, KoShapeSavingContext &context)
How do i store the style information of Complex borders, As it is possible to have \
different colors for different sides. 

Saving back the header/footer information is still not implemented. The \
header/footer-style should be saved as a child of the style:page-layout; but using \
the addChildElement its instead saved as a child of style:page-layout-properties. Any \
idea how this can be implemented ? 


Diffs (updated)
-----

  trunk/koffice/kword/part/KWCanvas.h 1051253 
  trunk/koffice/kword/part/KWCanvas.cpp 1051253 
  trunk/koffice/kword/part/KWOdfLoader.cpp 1051253 
  trunk/koffice/kword/part/KWPageStyle.h 1051253 
  trunk/koffice/kword/part/KWPageStyle.cpp 1051253 
  trunk/koffice/kword/part/KWPageStyle_p.h 1051253 
  trunk/koffice/kword/part/frames/KWTextFrameSet.h 1051253 
  trunk/koffice/kword/part/frames/KWTextFrameSet.cpp 1051253 
  trunk/koffice/libs/flake/CMakeLists.txt 1051253 
  trunk/koffice/libs/flake/KoFrameBorder.h PRE-CREATION 
  trunk/koffice/libs/flake/KoFrameBorder.cpp PRE-CREATION 
  trunk/koffice/libs/odf/KoBorder.h 1051253 
  trunk/koffice/libs/odf/KoBorder.cpp 1051253 
  trunk/koffice/libs/widgets/KoPageLayout.h 1051253 
  trunk/koffice/libs/widgets/KoPageLayout.cpp 1051253 

Diff: http://reviewboard.kde.org/r/2268/diff


Testing
-------

I have done testing with few documents and works fine.


Thanks,

Mani

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]