[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: A graph walker - base class for merging
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2009-11-20 13:44:02
Message-ID: 20091120134402.15055.46520 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2229/#review3182
-----------------------------------------------------------


It's okay, I guess, except for some niggles: 

s/crowling/crawling

The method name greetOnBackwardWay doesn't seem correct English: greetOnWayBack would \
perhaps be better, but I might have misunderstood its functios

I'd like some docs, including the purpose of the class in the class apidox, also some \
discussion on how this approach works in a multi-threaded environment.


- Boudewijn


On 2009-11-20 13:05:37, Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2229/
> -----------------------------------------------------------
> 
> (Updated 2009-11-20 13:05:37)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Added KisGraphWalker.
> 
> It walks through the graph and visits every node in a bottom-up way. It provides \
> essential options for caching projection and for collecting node's properties in a \
> reversed (top-down) way. It will be used in calculation of need/change rects for \
> nodes. 
> 
> Diffs
> -----
> 
> trunk/koffice/krita/image/CMakeLists.txt 1045641 
> trunk/koffice/krita/image/kis_graph_walker.h PRE-CREATION 
> trunk/koffice/krita/image/kis_graph_walker.cc PRE-CREATION 
> trunk/koffice/krita/image/tests/CMakeLists.txt 1045627 
> trunk/koffice/krita/image/tests/kis_graph_walker_test.h PRE-CREATION 
> trunk/koffice/krita/image/tests/kis_graph_walker_test.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/2229/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]