[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/plugins/defaultTools/defaulttool
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2009-11-17 12:14:41
Message-ID: 200911171314.41191.t.zachmann () zagge ! de
[Download RAW message or body]

On Tue November 17 2009, Thomas Zander wrote:
> On Tuesday 17. November 2009 04.13.59 Thorsten Zachmann wrote:
> > SVN commit 1050284 by zachmann:
> >
> > o Fix moving of grouped shapes by keyboard
> >
> > If a grouped shape was moved by keyboard and selected again the size of
> > the group was no longer the size of its members.
> 
> Could you please explain this a bit more?

The problem can seen when you group 2 shapes and then move them by keyboard. 
If you then reselect the group the bounding box is not as it should be.

> The group shape (KoShapeGroup) has this in its API docs;
>  "Note that while this object is also a shape, it is not actually visible
>   and the user can't interact with it."
> 
> In effect this means that the size of the group shape is totally
>  irrelevant. So I'm not sure what you are fixing here. I don't think this
>  change is correct.

It unifies the way how move commands are handled by the default tool to always 
use the same selection see:

./ShapeMoveStrategy.cpp:128:    return new 
KoShapeMoveCommand(m_selectedShapes, m_previousPositions, m_newPositions);

    m_tool->canvas()->addCommand( new KoShapeMoveCommand( selectedShapes, 
oldPositions, newPositions ) );


Thorsten
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]