'Re: Review Request: Master Notes for KPresenter'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Master Notes for KPresenter
From:       "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date:       2009-11-17 6:42:41
Message-ID: 20091117064241.11564.48799 () localhost
[Download RAW message or body]

> On 2009-11-17 03:25:16, Thorsten Zachmann wrote:
> > I have some functional questions. In the description you say the page image and \
> > the text shape of the notes page are comming from the notes master. However I \
> > can't see any shapes on the notes master. 
> > When I'm on the notes master view and use ctrl+A to select all objects the \
> > objects of the master page are selected and can be moved around. 
> > I still need to look at the patch more detailed. Please give me some more time as \
> > I'm quite busy at the moment.
> 
> Fredy Yanardi wrote:
> Yes, the thumbnail and the text shape come from the master. But the master need to \
> load it from the file first. To test it you need a file from OOo that contains the \
> master notes (just save a blank presentation in OOo). I'm planning to add notes \
> master to the template files used by KPresenter, so that the master page loaded for \
> the first time will be populated by necessary shapes. 
> I don't understand your second point, all objects inside the notes master view are \
> supposed to be selectable and movable. 
> No hurry to look at the patch, take your time :)

The reproduce the second problem do the following:

- Create an new empty presentation using the Empty Screen Template
- switch to "Show Notes Master"
- press Ctrl+A
- move your mouse over the canvas.
-> this will result in the objects from the master slide gets selected and can be \
modified.

- Thorsten

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2167/#review3134
-----------------------------------------------------------

On 2009-11-14 08:37:06, Fredy Yanardi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2167/
> -----------------------------------------------------------
> 
> (Updated 2009-11-14 08:37:06)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This is a patch to enable master notes for KPresenter. The patch is still work in \
> progress, but all basic functionality and all necessary changes are there. What \
> left is saving the master notes (I think). Here I list all proposed changes for \
> kopageapp and kpresenter: 
> For kopageapp, there are some changes in KoPAView and KoPAViewMode classes to \
> support the master notes and to allow more flexibility for similar feature in the \
> future (i.e: view mode that has normal and master mode): 1. Additional parameter \
> [bool master] for KoPAViewMode::setViewMode, to allow activating a view mode and \
> directly enable/disable master mode for that view mode. So now the function \
> signature is: void KoPAViewMode::setViewMode( KoPAViewMode *mode, bool master ); 2. \
> Additional parameter [bool updateShapeManager] for KoPAViewMode::setActivePage. \
> Currently if this method is called, the shape manager of the canvas is updated with \
> the page's shapes. But this is redundant for KPrViewModeNotes, since it needs to \
> update the shape manager with different set of shapes. The additional parameter \
> will tell the function whether to update the shape manager of not. So, the proposed \
> function signature is: void KoPAViewMode::setActivePage( KoPAPageBase *page, bool \
> updateShapeManager ); 3. Additional parameter [bool master] for \
> KoPAViewMode::activate to facilitate[1]. The function signature becomes: void \
> KoPAViewMode::activate( KoPAViewMode *previousViewMode, bool master ) 4. Additional \
> function KoPAView::setViewModeSavedPage( KoPAPageBase *page ) and \
> KoPAView::viewModeSavedPage(). The reason for this is because we need to save the \
> normal page (KoPAPage) when we go to master mode, so that if we go back to normal \
> mode again, that saved page can be activated. Previously only one view mode can go \
> to master mode, hence the KoPAPage is saved inside the KoPAViewModeNormal. But now \
> there are two view modes that can go to master mode, hence there must be a central \
> place to set and get the saved page. 5. Remove doUpdateActivePage function from \
> KoPAView, and do the updating of the active page in each view mode's \
>                 updateActivePage instead. There are two main reasons I propose this \
>                 change:
> * The implementation for updating active page is different in each view mode, and \
>                 it is only used in KoPAViewModeNormal.
> * Too many routing for this doUpdateActivePage. Currently for updating active page \
> of the KoPAViewModeNormal is: KoPAView::updateActivePage() -> \
> KoPAViewMode::updateActivePage()-> KoPAView::doUpdateActivePage(). (This is not \
> directly related to master notes, just to simplify and clean up a bit) 
> And for KPresenter itself:
> 1. Split KPrNotes into three classes: KPrNotesBase, KPrMasterNotes, and KPrNotes. \
> KPrNotes gets the thumbnail shape, text shape and page layout from KPrMasterNotes. \
> 2. Some changes in KPrViewModeNotes to support displaying notes and masternotes \
> shapes. 
> Any critics, comments or suggestions are greatly appreciated :)
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/kpresenter/part/CMakeLists.txt 1048872 
> /trunk/koffice/kpresenter/part/KPrMasterNotes.h PRE-CREATION 
> /trunk/koffice/kpresenter/part/KPrMasterNotes.cpp PRE-CREATION 
> /trunk/koffice/kpresenter/part/KPrMasterPage.h 1048872 
> /trunk/koffice/kpresenter/part/KPrMasterPage.cpp 1048872 
> /trunk/koffice/kpresenter/part/KPrNotes.h 1048872 
> /trunk/koffice/kpresenter/part/KPrNotes.cpp 1048872 
> /trunk/koffice/kpresenter/part/KPrNotesBase.h PRE-CREATION 
> /trunk/koffice/kpresenter/part/KPrNotesBase.cpp PRE-CREATION 
> /trunk/koffice/kpresenter/part/KPrView.h 1048872 
> /trunk/koffice/kpresenter/part/KPrView.cpp 1048872 
> /trunk/koffice/kpresenter/part/KPrViewModeNotes.h 1048872 
> /trunk/koffice/kpresenter/part/KPrViewModeNotes.cpp 1048872 
> /trunk/koffice/kpresenter/part/KPrViewModePresentation.h 1048872 
> /trunk/koffice/kpresenter/part/KPrViewModePresentation.cpp 1048872 
> /trunk/koffice/kpresenter/part/KPrViewModePreviewPageEffect.h 1048872 
> /trunk/koffice/kpresenter/part/KPrViewModePreviewPageEffect.cpp 1048872 
> /trunk/koffice/kpresenter/part/kpresenter.rc 1048872 
> /trunk/koffice/libs/kopageapp/KoPAView.h 1048872 
> /trunk/koffice/libs/kopageapp/KoPAView.cpp 1048872 
> /trunk/koffice/libs/kopageapp/KoPAViewMode.h 1048872 
> /trunk/koffice/libs/kopageapp/KoPAViewMode.cpp 1048872 
> /trunk/koffice/libs/kopageapp/KoPAViewModeNormal.h 1048872 
> /trunk/koffice/libs/kopageapp/KoPAViewModeNormal.cpp 1048872 
> 
> Diff: http://reviewboard.kde.org/r/2167/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fredy
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 