[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Refactor writing of styles.xml in libppt
From:       jos.van.den.oever () kogmbh ! com
Date:       2009-10-28 13:00:22
Message-ID: 20091028130022.24772.51226 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1999/
-----------------------------------------------------------

Review request for KOffice.


Summary
-------

Add a few improvements to libppt:

- use convenience class KoXmlWriter in generating the ODF
- use saveOdfStylesDotXml to create 'styles.xml' instead of with XML writer
- save picture names in manifest along with their mimetype.

The new code partially mimics filters/kpresenter/kpr2odf/Filterkpr2odf.cpp


Diffs
-----

  trunk/koffice/filters/kpresenter/powerpoint/import/pictures.h 1041440 
  trunk/koffice/filters/kpresenter/powerpoint/import/pictures.cc 1041440 
  trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h 1041440 
  trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1041440 

Diff: http://reviewboard.kde.org/r/1999/diff


Testing
-------

Ran filter across some ppt files and validated them with xmllint.


Thanks,

vandenoever

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]