[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch to fix multiple undo command on pasting page in kpresenter
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2009-10-28 8:18:09
Message-ID: 200910280918.09243.t.zachmann () zagge ! de
[Download RAW message or body]

On Wed October 28 2009, Pierre Stirnweiss wrote:
> > If there are no objections I will apply the patch to trunk. For 2.1 I
> > will come up with a different patch based on the begin/endMacro for
> > kopageapp. This
> > works but does not allow to have different command names which is why I
> > would
> > have preferred to fix the bug instead of working around it.
> 
> As far as I can tell, this is not possible because when
> setUndoRedoEnable(false) is called, it also clears up the QTextDocument
> undoStack. Which means that all the undoCommands on the application stack,
> prior to your paste command won't have their corresponding QTextDocument
> undoStack commands anymore. And I don't think that clearing the undo
>  history on the application each time a paste command is used is really
>  desirable.
> 

That should be no problem as load on the shape is only called during loading 
the shape and not while it already has some content. So there should be no 
commands in the QTextDocument stack which will be undone by the application 
after loading.											

> Meanwhile, for 2.1, in order to play safe, the other solution is better. If
> recreating the hole is the only possibility and proves harmless, we could
> always backport it for 2.1.1.

Agreed.

Thorsten
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]