[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Add ability to read,
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2009-10-22 15:24:35
Message-ID: 20091022152435.24193.76888 () localhost
[Download RAW message or body]
> On 2009-10-22 15:05:34, Thomas Zander wrote:
> > trunk/koffice/libs/odf/KoBorder.cpp, line 501
> > <http://reviewboard.kde.org/r/1890/diff/8/?file=13183#file13183line501>
> >
> > please don't parse the border data 4 times.
> > I think I mentioned this 5 times now...
oops! Sorry about that. I meant to include that fix, but forgot to do it. Fixed \
now.
- Inge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1890/#review2764
-----------------------------------------------------------
On 2009-10-22 14:40:20, Inge Wallin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1890/
> -----------------------------------------------------------
>
> (Updated 2009-10-22 14:40:20)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> This patch adds the ability to read, store and save page borders in text documents.
>
> So far it does not paint the borders, because I couldn't understand the paint code \
> of KWord, but I hope to get some help with that today.
>
> Diffs
> -----
>
> trunk/koffice/libs/kotext/KoTextBlockBorderData.cpp 1038962
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.h 1038962
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1038962
> trunk/koffice/libs/odf/CMakeLists.txt 1038962
> trunk/koffice/libs/odf/KoBorder.h PRE-CREATION
> trunk/koffice/libs/odf/KoBorder.cpp PRE-CREATION
> trunk/koffice/libs/widgets/KoPageLayout.h 1038962
> trunk/koffice/libs/widgets/KoPageLayout.cpp 1038962
> trunk/koffice/plugins/textshape/tests/TestDocumentLayout.cpp 1038962
>
> Diff: http://reviewboard.kde.org/r/1890/diff
>
>
> Testing
> -------
>
> I have tested with loading and saving a document that contains page borders created \
> in OOo.
>
> Thanks,
>
> Inge
>
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic