[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Patch to load correct version of textual content,
From:       "Thomas Zander" <zander () kde ! org>
Date:       2009-10-21 11:08:44
Message-ID: 20091021110844.18660.83825 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1919/#review2738
-----------------------------------------------------------



trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc
<http://reviewboard.kde.org/r/1919/#comment2058>

    Instead of using replace, I think you should use QString::remove()



trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp
<http://reviewboard.kde.org/r/1919/#comment2059>

    This constructor should not be needed



trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp
<http://reviewboard.kde.org/r/1919/#comment2060>

    This constructor should not be needed



trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp
<http://reviewboard.kde.org/r/1919/#comment2061>

    This constructor should not be needed



trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp
<http://reviewboard.kde.org/r/1919/#comment2063>

    A QString does not have to be initialized. This line does nothing.



trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp
<http://reviewboard.kde.org/r/1919/#comment2062>

    This constructor should not be needed



trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp
<http://reviewboard.kde.org/r/1919/#comment2066>

    This constructor should not be needed



trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp
<http://reviewboard.kde.org/r/1919/#comment2064>

    A QString does not have to be initialized. This just slows things down :)



trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp
<http://reviewboard.kde.org/r/1919/#comment2065>

    This constructor should not be needed



trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp
<http://reviewboard.kde.org/r/1919/#comment2067>

    use name.clear() instead, which is much faster.



trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp
<http://reviewboard.kde.org/r/1919/#comment2068>

    This constructor should not be needed



trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp
<http://reviewboard.kde.org/r/1919/#comment2069>

    This constructor should not be needed



trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp
<http://reviewboard.kde.org/r/1919/#comment2070>

    This constructor should not be needed



trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp
<http://reviewboard.kde.org/r/1919/#comment2071>

    This constructor should not be needed



trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp
<http://reviewboard.kde.org/r/1919/#comment2072>

    unsigned char * ?  Why the 'unsigned' ?



trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp
<http://reviewboard.kde.org/r/1919/#comment2073>

    that unsigned too is weird here...


- Thomas


On 2009-10-21 09:36:15, Vesa Pikki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1919/
> -----------------------------------------------------------
> 
> (Updated 2009-10-21 09:36:15)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch fixes font name loading, text bytes and chars loading. 
> Powerpoint files contain version history of changes. Currently the oldest version \
> of DocumentContainer is loaded. This patch mofies DocumentContainer loading to use \
> latest version available. This in turn ensures that the latest texts and text \
> styles are loaded. 
> This patch renames some related datatypes to match those in powerpoint's definition \
> to make it easier to follow the specification.  Some powerpoint data structures \
> were also modified to use QSharedData & QSharedDataPointer. 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1038383 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.h 1038383 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/objects.cpp 1038383 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.h 1038383 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp 1038383 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/presentation.h 1038383 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/presentation.cpp 1038383 
> 
> Diff: http://reviewboard.kde.org/r/1919/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vesa
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]