[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add ability to read,
From:       Thomas Zander <zander () kde ! org>
Date:       2009-10-21 7:24:17
Message-ID: 200910210924.18722.zander () kde ! org
[Download RAW message or body]

On Wednesday 21. October 2009 02.47.36 Inge Wallin wrote:
> > > > >     Please don't parse each item 4 times, store it in an
> > > > > intermediate variable.
> > >
> > > Copied from your own code, but I fixed it here.  I suggest you do the
> > > same in ParagraphStyle :-)
> >
> > Your patch 6 doesn't show this fix.
>
> Yes it does.  The code now uses QString::split instead of parsing.  Can
> you find a spot where it doesn't, then I will change that too, but
> everywhere I looked it's fixed.
Hehe, confusion :)
I don't care too much about the splitting of the string, what I tried to 
address here is that each string part is parsed multiple times using the 
same call (KoUnit::parseSomething()), which is unneeded, once is enough.

-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]