[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add ability to read,
From:       "Thomas Zander" <zander () kde ! org>
Date:       2009-10-20 9:36:13
Message-ID: 20091020093613.14084.90139 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1890/#review2724
-----------------------------------------------------------



trunk/koffice/libs/odf/KoBorder.cpp
<http://reviewboard.kde.org/r/1890/#comment2037>

    trailing space



trunk/koffice/libs/odf/KoBorder.cpp
<http://reviewboard.kde.org/r/1890/#comment2028>

    this constructor is not needed



trunk/koffice/libs/odf/KoBorder.cpp
<http://reviewboard.kde.org/r/1890/#comment2029>

    just copy the d, not create a new one and a line later replace it.



trunk/koffice/libs/odf/KoBorder.cpp
<http://reviewboard.kde.org/r/1890/#comment2030>

    please add a check if the d pointer is identical too.



trunk/koffice/libs/odf/KoBorder.cpp
<http://reviewboard.kde.org/r/1890/#comment2031>

    I don't think this solution scales very well, if ODF doesn't support it we have \
to either;  a) choose to support it and push it into ODF
    b) choose to not support it and just store it as an anonymous feature we just \
read and write out.  c) ignore it.
    
    Adding a lot of styles and hinting we want to add more for MSDoc is not something \
that scales.



trunk/koffice/libs/odf/KoBorder.cpp
<http://reviewboard.kde.org/r/1890/#comment2032>

    Please don't parse each item 4 times, store it in an intermediate variable.



trunk/koffice/libs/odf/KoBorder.cpp
<http://reviewboard.kde.org/r/1890/#comment2033>

    Please place the curly brace one line up.



trunk/koffice/libs/odf/KoBorder.cpp
<http://reviewboard.kde.org/r/1890/#comment2034>

    Please place the curly brace one line up.



trunk/koffice/libs/widgets/KoPageLayout.h
<http://reviewboard.kde.org/r/1890/#comment2035>

    Why did you write this? How is the operator= different from the auto generated \
one for a struct?



trunk/koffice/libs/widgets/KoPageLayout.cpp
<http://reviewboard.kde.org/r/1890/#comment2036>

    trailing space


- Thomas


On 2009-10-20 07:29:43, Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1890/
> -----------------------------------------------------------
> 
> (Updated 2009-10-20 07:29:43)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to read, store and save page borders in text documents.
> 
> So far it does not paint the borders, because I couldn't understand the paint code \
> of KWord, but I hope to get some help with that today. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/widgets/KoPageLayout.h 1037806 
> trunk/koffice/libs/widgets/KoPageLayout.cpp 1037806 
> trunk/koffice/libs/odf/KoBorder.cpp PRE-CREATION 
> trunk/koffice/libs/odf/CMakeLists.txt 1037806 
> trunk/koffice/libs/odf/KoBorder.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1890/diff
> 
> 
> Testing
> -------
> 
> I have tested with loading and saving a document that contains page borders created \
> in OOo. 
> 
> Thanks,
> 
> Inge
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]