[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/libs/flake/tests
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2009-09-27 10:29:32
Message-ID: 200909271229.32842.t.zachmann () zagge ! de
[Download RAW message or body]

On Sat September 26 2009, Thomas Zander wrote:
> On Friday 25. September 2009 19.38.15 jaham@gmx.net wrote:
> > I don't think it is too complex, just a recursive function which gets a
> > list of shapes to paint and when stumbling over a shape container calls
> > itself with the containers child shapes.
> > But if you have a better idea to get the same result by sorting the list
> > of shapes, i am all for it. The important thing is that it works.
> 
> I think the attached patch is a good way to do it, sorting the list makes
> sure the painting order is correct.
> I committed a (failing) test to show the *painting* issue in the fullest.
> 
> What do you think about this patch?
> 

That is in the way what I had in mind too. However that is only a part of what 
needs fixing. It is still possible that two shapes can get the same z-index.

I was comparing your compare algorithm to one a different one too see 
what is faster, when I found a problem with your algorithem:

The following

layer 1
group 1.1
  member 1.1.1
  member 1.1.2
group 1.2
    member 1.2.1
    member 1.2.2

is sorted as:

layer 1
group 1.1
group 1.2
  member 1.1.1
  member 1.1.2
  member 1.2.1
  member 1.2.2

which is wrong.

We also need a resolution to the problem that when loading a file a hierarchy 
of shapes with layers is not a must. Otherwise we will reorder the shape which 
should be avoided.

As said I will work on this. I will post for review before committing. If you 
want to fix all this please let me know so that we don't do the work twice.

Thorsten
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]