[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Selection marks in the kword horizontal ruler
From:       "Thomas Zander" <zander () kde ! org>
Date:       2009-09-23 21:23:22
Message-ID: 20090923212322.15653.91944 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1693/#review2437
-----------------------------------------------------------


Looks good, I'll try to apply the patch tomorrow. 2 comments about the patch itself;


trunk/koffice/libs/main/KoView.cpp
<http://reviewboard.kde.org/r/1693/#comment1750>

    I suggest to move this to the constructor of the UnitChangeAction



trunk/koffice/libs/main/KoView.cpp
<http://reviewboard.kde.org/r/1693/#comment1752>

    is an addAction really needed?


- Thomas


On 2009-09-23 18:10:37, Paul wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1693/
> -----------------------------------------------------------
> 
> (Updated 2009-09-23 18:10:37)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> add radio buttons to the kword horizontal ruler pop-up menu
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/libs/main/KoView.cpp 1027268 
> 
> Diff: http://reviewboard.kde.org/r/1693/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> ruler
>   http://reviewboard.kde.org/r/1693/s/212/
> 
> 
> Thanks,
> 
> Paul
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]