[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Selection marks in the kword horizontal ruler
From:       "Thomas Zander" <zander () kde ! org>
Date:       2009-09-23 12:32:59
Message-ID: 20090923123259.3466.95799 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1693/#review2423
-----------------------------------------------------------



trunk/koffice/kword/part/KWGui.cpp
<http://reviewboard.kde.org/r/1693/#comment1730>

    The QActionGroup is correct, but i think it should be added in \
KoView::createChangeUnitActions() instead.



trunk/koffice/kword/part/KWGui.cpp
<http://reviewboard.kde.org/r/1693/#comment1731>

    The setCheckable is correct, but I think it should be added in the \
UnitChangeAction class instead (koffice/libs/main/KoView_p.h)



trunk/koffice/kword/part/KWGui.cpp
<http://reviewboard.kde.org/r/1693/#comment1732>

    Comparing the num is correct, but I think we should move the right side of the \
comparison to be outside of the loop so we don't do that indexInList 10 times, but \
just once.  
    Also, this could likely be done in the KoView::createChangeUnitActions() instead.


- Thomas


On 2009-09-22 16:26:34, Paul wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1693/
> -----------------------------------------------------------
> 
> (Updated 2009-09-22 16:26:34)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> add radio buttons to the kword horizontal ruler pop-up menu
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWGui.cpp 1026784 
> 
> Diff: http://reviewboard.kde.org/r/1693/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> ruler
> http://reviewboard.kde.org/r/1693/s/212/
> 
> 
> Thanks,
> 
> Paul
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]