[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: KWord: save and load  KWStatusBar configuration.
From:       "Thomas Zander" <zander () kde ! org>
Date:       2009-09-19 17:15:41
Message-ID: 20090919171541.12487.57701 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1650/#review2400
-----------------------------------------------------------



/trunk/koffice/kword/part/KWApplicationConfig.h
<http://reviewboard.kde.org/r/1650/#comment1703>

    that 'void' is a c-ism. Please remove.



/trunk/koffice/kword/part/KWApplicationConfig.cpp
<http://reviewboard.kde.org/r/1650/#comment1704>

    These variables are a bit confusing out of context. I suggest to use the word; \
"Show" in them.  Like StatusBarShowModified


- Thomas


On 2009-09-19 16:27:46, Jon de Andres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1650/
> -----------------------------------------------------------
> 
> (Updated 2009-09-19 16:27:46)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Saves the status bar config and loads it when kword starts. It uses the [Interface] \
> group, what perhaps should be changed. 
> 
> Diffs
> -----
> 
> /trunk/koffice/kword/part/KWApplicationConfig.h 1025739 
> /trunk/koffice/kword/part/KWApplicationConfig.cpp 1025739 
> /trunk/koffice/kword/part/KWStatusBar.h 1025739 
> /trunk/koffice/kword/part/KWStatusBar.cpp 1025739 
> 
> Diff: http://reviewboard.kde.org/r/1650/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]