[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Make paths in KOffice applications' window title
From:       "Cyrille Berger" <cberger () cberger ! net>
Date:       2009-08-21 7:18:58
Message-ID: 20090821071858.11506.24868 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1377/#review2102
-----------------------------------------------------------

Ship it!


sounds good.

- Cyrille


On 2009-08-20 21:23:57, Jaroslaw Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1377/
> -----------------------------------------------------------
> 
> (Updated 2009-08-20 21:23:57)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> KoMainWindow and KoDocument contain copy/pasted code that generated string \
> displayed in the window title. The form is "[title] - [url]", built out of the \
> document info (title) and pretty-printed document URL. If the title is not present, \
> only the URL it returned. 
> The patch is extracts common code for the above into a separate function and uses \
> the function in two places. 
> The visible change is for MS Windows targets only: absolute paths are displayed \
> natively, e.g. as "C:\foo.odt", instead of "C:/foo.odt". This helps to make the \
> KOffice suite look more native on the OS. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/main/KoDocument.h 1013820 
> trunk/koffice/libs/main/KoDocument.cpp 1013820 
> trunk/koffice/libs/main/KoMainWindow.cpp 1013820 
> 
> Diff: http://reviewboard.kde.org/r/1377/diff
> 
> 
> Testing
> -------
> 
> Tested with KWord, etc.
> 
> 
> Thanks,
> 
> Jaroslaw
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]