[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Initial instance for KoTextEditor
From:       "Pierre Stirnweiss" <pstirnweiss () googlemail ! com>
Date:       2009-08-01 14:08:40
Message-ID: 20090801140840.16319.42195 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1212/
-----------------------------------------------------------

Review request for KOffice.


Summary
-------

This is an initial instance of the KoTextEditor. I am going on holiday tomorrow and \
will probably not be able to connect to Internet. I'll be able to code, but not to \
sync or get feedback. I'd be grateful if some of you could try this out as I'd like \
it to be part of 2.1. It is not only a fix for a bug we have (scripts will mess our \
undo/redo), but is also a ground building brick for further change tracking. \
Basically, the KoTextEditor is supposed to supersede the KoTextSelectionHandler. It \
does the same thing but handle the undo/redo mechanism (as opposed to before where \
the undo/redo was handled by the tool). So if some of you could give it a spin in the \
next couple of weeks and give me feed-back when I am back from holiday, I'd \
appreciate. In order for the undo/redo in TextShapes to work in any given app, the \
KoDocument::undoStack() needs to be populated in the dataCenterMap. I can take care \
of this, but so far it is only done for KWord.

Thanks for your help,

Pierre


Diffs
-----

  trunk/koffice/kword/part/KWDocument.cpp 1005434 
  trunk/koffice/kword/part/KWView.cpp 1005434 
  trunk/koffice/kword/part/frames/KWTextFrameSet.cpp 1005434 
  trunk/koffice/kword/plugins/scripting/Tool.h 1005434 
  trunk/koffice/libs/kotext/CMakeLists.txt 1005434 
  trunk/koffice/libs/kotext/InsertVariableActionBase.cpp 1005434 
  trunk/koffice/libs/kotext/KoTextDocument.h 1005434 
  trunk/koffice/libs/kotext/KoTextDocument.cpp 1005434 
  trunk/koffice/libs/kotext/KoTextEditor.h PRE-CREATION 
  trunk/koffice/libs/kotext/KoTextEditor.cpp PRE-CREATION 
  trunk/koffice/libs/kotext/changetracker/KoChangeTracker.h 1005434 
  trunk/koffice/libs/kotext/changetracker/KoChangeTracker.cpp 1005434 
  trunk/koffice/libs/kotext/changetracker/KoDeleteChangeMarker.cpp 1005434 
  trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1005434 
  trunk/koffice/libs/main/CMakeLists.txt 1005434 
  trunk/koffice/libs/main/KoDocument.h 1005434 
  trunk/koffice/libs/main/KoDocument.cpp 1005434 
  trunk/koffice/libs/main/KoUndoStack.h PRE-CREATION 
  trunk/koffice/libs/main/KoUndoStack.cpp PRE-CREATION 
  trunk/koffice/plugins/simpletextedit/Panel.h 1005434 
  trunk/koffice/plugins/simpletextedit/Panel.cpp 1005434 
  trunk/koffice/plugins/textshape/CMakeLists.txt 1005434 
  trunk/koffice/plugins/textshape/TextShape.cpp 1005434 
  trunk/koffice/plugins/textshape/TextTool.h 1005434 
  trunk/koffice/plugins/textshape/TextTool.cpp 1005434 
  trunk/koffice/plugins/textshape/commands/ChangeListCommand.cpp 1005434 
  trunk/koffice/plugins/textshape/commands/ChangeListLevelCommand.cpp 1005434 
  trunk/koffice/plugins/textshape/commands/TextCutCommand.h PRE-CREATION 
  trunk/koffice/plugins/textshape/commands/TextPasteCommand.cpp PRE-CREATION 
  trunk/koffice/plugins/textshape/tests/CMakeLists.txt 1005434 

Diff: http://reviewboard.kde.org/r/1212/diff


Testing
-------

It compiles OK, and it seems like most editing commands work fine.


Thanks,

Pierre

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]