[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [patch] Avoid crash in KoColorPopupAction
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2009-07-31 6:02:14
Message-ID: 200907310802.15159.boud () valdyas ! org
[Download RAW message or body]

On Thursday 30 July 2009, Jarosław Staniek wrote:
> Hi, for review:
> When KoColorPopupAction (for whatever reason) receives invalid QColor,
> KoColor asserts [1].
>
> The patch falls back to transparent black color and issues a warning.
>
> [1] KoColor::KoColor(const QColor & color, const KoColorSpace * colorSpace)

Looks good, though I am open to removing the assert and defaulting to black 
inside KoColor, too, when given an invalid QColor.

-- 
Boudewijn Rempt | http://www.valdyas.org

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]